go-bds/Maneger
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Releases 71 Wiki Activity

Merge #31

Merged
Sirherobrine23 merged 14 commits from main into stable 2021-02-09 17:53:17 +00:00
Conversation 5 Commits 14 Files Changed 21 +4019 -319
Sirherobrine23 commented 2021-02-09 09:29:00 +00:00
Owner
Copy Link
No description provided.
ghost commented 2021-02-09 09:29:11 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

DeepCode's analysis on #54a6ff found:

  • ⚠️ 1 warning 👇
  • ✔️ 6 issues were fixed.

Top issues

Description Example fixes
Two subsequent branches of an if statement have duplicate bodies (here and here). This may be caused by a copy-paste error. If this usage is intentional, consider merging the branches to avoid code duplication. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

## DeepCode's analysis on [#54a6ff](https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/e003eae066760737a492d6840052f2a1d2b870d9/Bds-Maneger/bds_maneger_api/54a6ff7f8968228ebeba5144f93230a2b8b1c6ec/pr/_/%2F/code/?utm_source=gh_review&c=0&w=1&i=0&) found: - :warning: **1** warning :point_down: - :heavy_check_mark: **6** issues were fixed. ## Top issues <table> <thead> <tr> <th align="left">Description</th> <th align="left">Example fixes</th> </tr> </thead> <tbody> <tr> <td width="77%">Two subsequent branches of an if statement have duplicate bodies (here and here). This may be caused by a copy-paste error. If this usage is intentional, consider merging the branches to avoid code duplication. Occurrences: <ul><li><a href="https://github.com/Bds-Maneger/bds_maneger_api/blob/54a6ff7f8968228ebeba5144f93230a2b8b1c6ec/index.js#L178">index.js:178</a></li></ul></td> <td width="23%"><a href="https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/e003eae066760737a492d6840052f2a1d2b870d9/Bds-Maneger/bds_maneger_api/54a6ff7f8968228ebeba5144f93230a2b8b1c6ec/pr/_/%2Findex.js/javascript%2Fdc_interfile_project%2FDuplicateIfBody/code/?utm_source=gh_review&">:wrench: Example fixes</a></td> </tr> </tbody> </table> #### 👉 View analysis in [**DeepCode’s Dashboard**](https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/e003eae066760737a492d6840052f2a1d2b870d9/Bds-Maneger/bds_maneger_api/54a6ff7f8968228ebeba5144f93230a2b8b1c6ec/pr/_/%2F/code/?utm_source=gh_review&c=0&w=1&i=0&) | [_Configure the bot_](https://www.deepcode.ai/app/gh/?ownerconfig=Bds-Maneger)
lgtm-com[bot] commented 2021-02-09 09:31:59 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

This pull request introduces 2 alerts and fixes 5 when merging db077656ec into e003eae066 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Syntax error

fixed alerts:

  • 2 for Deleting non-property
  • 1 for Expression has no effect
  • 1 for Unused variable, import, function or class
  • 1 for Missing rate limiting
This pull request **introduces 2 alerts** and **fixes 5** when merging db077656ec8d59217262da1de501a5614f8c010c into e003eae066760737a492d6840052f2a1d2b870d9 - [view on LGTM.com](https://lgtm.com/projects/g/Bds-Maneger/bds_maneger_api/rev/pr-084f0f623636a826666a46d0187f1cdadb316259) **new alerts:** * 1 for Expression has no effect * 1 for Syntax error **fixed alerts:** * 2 for Deleting non\-property * 1 for Expression has no effect * 1 for Unused variable, import, function or class * 1 for Missing rate limiting
lgtm-com[bot] commented 2021-02-09 10:47:33 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

This pull request introduces 2 alerts and fixes 5 when merging 20751eb40a into e003eae066 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Syntax error

fixed alerts:

  • 2 for Deleting non-property
  • 1 for Expression has no effect
  • 1 for Unused variable, import, function or class
  • 1 for Missing rate limiting
This pull request **introduces 2 alerts** and **fixes 5** when merging 20751eb40a5c4d9be11540d0c2818bd2c0cabb5b into e003eae066760737a492d6840052f2a1d2b870d9 - [view on LGTM.com](https://lgtm.com/projects/g/Bds-Maneger/bds_maneger_api/rev/pr-70207c56d8095ce9199dfa12d42cc1e8a66b398d) **new alerts:** * 1 for Expression has no effect * 1 for Syntax error **fixed alerts:** * 2 for Deleting non\-property * 1 for Expression has no effect * 1 for Unused variable, import, function or class * 1 for Missing rate limiting
lgtm-com[bot] commented 2021-02-09 17:47:32 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

This pull request introduces 2 alerts and fixes 8 when merging 54a6ff7f89 into e003eae066 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Useless conditional

fixed alerts:

  • 3 for Missing variable declaration
  • 2 for Deleting non-property
  • 1 for Expression has no effect
  • 1 for Unused variable, import, function or class
  • 1 for Missing rate limiting
This pull request **introduces 2 alerts** and **fixes 8** when merging 54a6ff7f8968228ebeba5144f93230a2b8b1c6ec into e003eae066760737a492d6840052f2a1d2b870d9 - [view on LGTM.com](https://lgtm.com/projects/g/Bds-Maneger/bds_maneger_api/rev/pr-d75eb964540bff0f0700b4dac2b275d30672d6db) **new alerts:** * 1 for Expression has no effect * 1 for Useless conditional **fixed alerts:** * 3 for Missing variable declaration * 2 for Deleting non\-property * 1 for Expression has no effect * 1 for Unused variable, import, function or class * 1 for Missing rate limiting
lgtm-com[bot] commented 2021-02-09 17:53:04 +00:00 (Migrated from github.com)
Author
Owner
Copy Link

This pull request introduces 2 alerts and fixes 8 when merging b94b7d5509 into e003eae066 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Useless conditional

fixed alerts:

  • 3 for Missing variable declaration
  • 2 for Deleting non-property
  • 1 for Expression has no effect
  • 1 for Unused variable, import, function or class
  • 1 for Missing rate limiting
This pull request **introduces 2 alerts** and **fixes 8** when merging b94b7d55096644875d1fc656dec8f345fbad93a2 into e003eae066760737a492d6840052f2a1d2b870d9 - [view on LGTM.com](https://lgtm.com/projects/g/Bds-Maneger/bds_maneger_api/rev/pr-42aaee38c58029da3ba8e66edabee835326af39c) **new alerts:** * 1 for Expression has no effect * 1 for Useless conditional **fixed alerts:** * 3 for Missing variable declaration * 2 for Deleting non\-property * 1 for Expression has no effect * 1 for Unused variable, import, function or class * 1 for Missing rate limiting
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
github_actions
Pull requests that update Github_actions code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
javascript
Pull requests that update Javascript code
question
Further information is requested
Sirherobrine23
Sirherobrine23 Developments and features
wontfix
This will not be worked on
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: go-bds/Maneger#31
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?