Merge #20

Sirherobrine23 · 2021-01-31T02:41:41Z

Sirherobrine23 commented

2021-01-31 02:41:41 +00:00

Much of the Javascript files were reformulated, the next commits in the main branch will be for correction in the Docker image.

ghost commented

2021-01-31 02:41:50 +00:00

(Migrated from github.com)

DeepCode's analysis on #624d1d found:

❌ 1 critical issue, ⚠️ 5 warnings, ℹ️ 2 minor issues. 👇
✔️ 2 issues were fixed.

Top issues

Description	Example fixes
Unsanitized input from an HTTP parameter flows into send, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS). Occurrences: gdrive_save.js:11	🔧 Example fixes
Disable X-Powered-By header for your Express app (consider using Helmet middleware), because it exposes information about the used framework to potential attackers. Occurrences: gdrive_save.js:4	🔧 Example fixes
Comparing a number (from number literal 0) and a string (from string literal "-0") might behave differently than expected, as implicit conversion is performed. Consider making the conversion explicit if you intend it. Occurrences: backups.js:70	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

## DeepCode's analysis on [#624d1d](https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/1c60064d81dd05086570e46e1f0f2eb123e89ddd/Bds-Maneger/bds_maneger_api/624d1dfba07b1386106b0317a83e8d91fa87f695/pr/_/%2F/code/?utm_source=gh_review&c=1&w=5&i=2&) found: - :x: **1** critical issue, :warning: **5** warnings, :information_source: **2** minor issues. :point_down: - :heavy_check_mark: **2** issues were fixed. ## Top issues <table> <thead> <tr> <th align="left">Description</th> <th align="left">Example fixes</th> </tr> </thead> <tbody> <tr> <td width="77%">Unsanitized input from an HTTP parameter flows into send, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS). Occurrences: <ul><li><a href="https://github.com/Bds-Maneger/bds_maneger_api/blob/624d1dfba07b1386106b0317a83e8d91fa87f695/API/gdrive_save.js#L11">gdrive_save.js:11</a></li></ul></td> <td width="23%"><a href="https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/1c60064d81dd05086570e46e1f0f2eb123e89ddd/Bds-Maneger/bds_maneger_api/624d1dfba07b1386106b0317a83e8d91fa87f695/pr/_/%2FAPI%2Fgdrive_save.js/javascript%2Fdc_interfile_project%2FXSS/code/?utm_source=gh_review&">:wrench: Example fixes</a></td> </tr> <tr> <td width="77%">Disable X-Powered-By header for your Express app (consider using Helmet middleware), because it exposes information about the used framework to potential attackers. Occurrences: <ul><li><a href="https://github.com/Bds-Maneger/bds_maneger_api/blob/624d1dfba07b1386106b0317a83e8d91fa87f695/API/gdrive_save.js#L4">gdrive_save.js:4</a></li></ul></td> <td width="23%"><a href="https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/1c60064d81dd05086570e46e1f0f2eb123e89ddd/Bds-Maneger/bds_maneger_api/624d1dfba07b1386106b0317a83e8d91fa87f695/pr/_/%2FAPI%2Fgdrive_save.js/javascript%2Fdc_interfile_project%2FDisablePoweredBy/code/?utm_source=gh_review&">:wrench: Example fixes</a></td> </tr> <tr> <td width="77%">Comparing a number (from number literal 0) and a string (from string literal "-0") might behave differently than expected, as implicit conversion is performed. Consider making the conversion explicit if you intend it. Occurrences: <ul><li><a href="https://github.com/Bds-Maneger/bds_maneger_api/blob/624d1dfba07b1386106b0317a83e8d91fa87f695/new_script/backups.js#L70">backups.js:70</a></li></ul></td> <td width="23%"><a href="https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/1c60064d81dd05086570e46e1f0f2eb123e89ddd/Bds-Maneger/bds_maneger_api/624d1dfba07b1386106b0317a83e8d91fa87f695/pr/_/%2Fnew_script%2Fbackups.js/javascript%2Fdc_interfile_project%2FIncompatibleTypesInComparison/code/?utm_source=gh_review&">:wrench: Example fixes</a></td> </tr> </tbody> </table> #### 👉 View analysis in [**DeepCode’s Dashboard**](https://www.deepcode.ai/app/gh/Bds-Maneger/bds_maneger_api/1c60064d81dd05086570e46e1f0f2eb123e89ddd/Bds-Maneger/bds_maneger_api/624d1dfba07b1386106b0317a83e8d91fa87f695/pr/_/%2F/code/?utm_source=gh_review&c=1&w=5&i=2&) | [_Configure the bot_](https://www.deepcode.ai/app/gh/?ownerconfig=Bds-Maneger)

lgtm-com[bot] commented

2021-01-31 02:45:11 +00:00

(Migrated from github.com)

This pull request introduces 8 alerts and fixes 21 when merging 624d1dfba0 into 1c60064d81 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class
2 for Deleting non-property
1 for Expression has no effect
1 for Reflected cross-site scripting

fixed alerts:

19 for Unused variable, import, function or class
2 for Deleting non-property

This pull request **introduces 8 alerts** and **fixes 21** when merging 624d1dfba07b1386106b0317a83e8d91fa87f695 into 1c60064d81dd05086570e46e1f0f2eb123e89ddd - [view on LGTM.com](https://lgtm.com/projects/g/Bds-Maneger/bds_maneger_api/rev/pr-376ca345cb97c058e198ed6d456f03fefce6f4d0) **new alerts:** * 4 for Unused variable, import, function or class * 2 for Deleting non\-property * 1 for Expression has no effect * 1 for Reflected cross\-site scripting **fixed alerts:** * 19 for Unused variable, import, function or class * 2 for Deleting non\-property

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: go-bds/Maneger#20