WIP: Rewrite package with napi-go #18

Draft

Sirherobrine23 wants to merge 3 commits from go-napi into main

pull from: go-napi

merge into: Wireguard:main

Wireguard:main

Wireguard:prebuilds

Conversation 0 Commits 3 Files Changed 35 +320 -5030

Sirherobrine23 commented 2025-04-23 23:39:58 +00:00

Owner

Copy Link

No description provided.

Sirherobrine23 added the Kind/FeatureKind/EnhancementKind/SecurityKind/Documentation

Priority

Critical

Kind/TestingCompat/Breaking labels 2025-04-23 23:39:58 +00:00

Sirherobrine23 self-assigned this 2025-04-23 23:39:58 +00:00

Sirherobrine23 added 1 commit 2025-04-23 23:39:58 +00:00

Init go mod 6364237045

Sirherobrine23 added this to the v2 project 2025-04-23 23:39:59 +00:00

Sirherobrine23 added 1 commit 2025-04-28 02:34:37 +00:00

Refactor N-API addon and switch binding library ... 21312c7378

Replace the old `addon` package with `wg_addon` and switch the N-API
binding library from `abhisekp/napi-go` to
`Sirherobrine23/napi-go`.

This restructures the code to use `wgctrl` for Linux/Windows in
`wg_addon/wgctrl.go` and stubs a `wireguard-go` based implementation
for other Unix systems in `wg_addon/unix.go`. N-API registration and
common types are now in `wg_addon/addon.go`.

The implementation leverages features of the new N-API library, such as
struct tags for automatic marshalling and simplified async worker
creation.

Sirherobrine23 added 1 commit 2025-04-28 22:28:14 +00:00

Refactor: Simplify wgctrl funcs & update napi-go ... 61dcda8662

Change SetInterface and GetInterface to standard Go functions,
removing direct NAPI handling and async logic from wgctrl.go.

Use napi.GoFuncOf for function registration in addon.go.
Update napi-go dependency to v0.1.2 pre-release.

Some checks failed

Hide all checks

Test / Test Linux (latest) (pull_request) Failing after 1m55s

Details

Test / Test Linux (20.x) (pull_request) Failing after 1m58s

Details

Test / Test Linux (21.x) (pull_request) Failing after 1m55s

Details

Test / Test Linux (18.x) (pull_request) Failing after 1m57s

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin go-napi:go-napi

git checkout go-napi

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No Label Compat/Breaking Kind/Documentation Kind/Enhancement Kind/Feature Kind/Security Kind/Testing

Priority

Critical

Milestone

No items

No Milestone

Projects

Clear projects

No project v2

Assignees

Clear assignees

Sirherobrine23

No Assignees Sirherobrine23

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Wireguard/Wireguard-tools.js#18

No description provided.