Sirherobrine23/napi-go
1
0
Fork 0
Code Issues 1 Pull Requests Actions Releases 2 Activity

WIP: feat(node_api): Add missing functions #7

Closed
abhisekp wants to merge 6 commits from abhisekp/feat-missing-functions into main
pull from: abhisekp/feat-missing-functions
merge into: Sirherobrine23:main
Conversation 3 Commits 6 Files Changed 11 +1441 -5
abhisekp commented 2025-02-15 16:16:58 +00:00 (Migrated from github.com)
Copy Link

Need proper testing

These are created using Cursor IDE using gpt4o using the following link as reference https://nodejs.org/docs/latest/api/n-api.html

# Need proper testing These are created using Cursor IDE using gpt4o using the following link as reference https://nodejs.org/docs/latest/api/n-api.html
abhisekp commented 2025-02-15 18:51:07 +00:00 (Migrated from github.com)
Copy Link

@akshayganeshen Please review. Wherever required you can make the changes or ask me to make them.
And then we can finalize for this to merge.

I'm very new to these things. I learnt about this yesterday and released a package using this library to demonstrate various use cases https://www.npmjs.com/package/@abhisekp/go-native

@akshayganeshen Please review. Wherever required you can make the changes or ask me to make them. And then we can finalize for this to merge. I'm very new to these things. I learnt about this yesterday and released a package using this library to demonstrate various use cases https://www.npmjs.com/package/@abhisekp/go-native
abhisekp commented 2025-02-15 22:03:08 +00:00 (Migrated from github.com)
Copy Link

Meanwhile, I have the new code ready for install https://github.com/abhisekp/napi-go

go get github.com/abhisekp/napi-go
Meanwhile, I have the new code ready for install https://github.com/abhisekp/napi-go ```sh go get github.com/abhisekp/napi-go ```
🎉 1 🚀 1
akshayganeshen commented 2025-02-25 01:52:51 +00:00 (Migrated from github.com)
Copy Link

Hey @abhisekp, this is really great! Thank you so much for putting this together!

I'll need a few weeks to test it, the plan is to just put together enough docs/examples/ to cover everything new. I'll also want to tweak the CONTRIBUTING.md guidelines a bit since I never really fleshed that out, but that's a pretty minor piece.

Will let you know if there's any changes I want to request, but for now this seems pretty solid.

Hey @abhisekp, this is really great! Thank you so much for putting this together! I'll need a few weeks to test it, the plan is to just put together enough `docs/examples/` to cover everything new. I'll also want to tweak the `CONTRIBUTING.md` guidelines a bit since I never really fleshed that out, but that's a pretty minor piece. Will let you know if there's any changes I want to request, but for now this seems pretty solid.
Sirherobrine23 closed this pull request 2025-04-27 03:07:20 +00:00
Sirherobrine23 deleted branch abhisekp/feat-missing-functions 2025-04-27 03:07:26 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Sirherobrine23
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sirherobrine23/napi-go#7
No description provided.
Delete Branch "abhisekp/feat-missing-functions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?