Sirherobrine23/Jellyfin_Xtream
1
0
Fork 0
Code Issues 26 Pull Requests 6 Actions Releases Wiki Activity

Handle seasons with a "null" air date #175

Open
Kevinjil wants to merge 2 commits from fix/empty-air-date into master
pull from: fix/empty-air-date
merge into: Sirherobrine23:master
Conversation 3 Commits 2 Files Changed 2 +45 -1
Kevinjil commented 2025-04-19 10:18:59 +00:00 (Migrated from github.com)
Copy Link

Fixes #151

Fixes #151
Kevinjil commented 2025-04-19 10:19:34 +00:00 (Migrated from github.com)
Copy Link

@martenumberto Since you seem to have the data available, would you mind testing this change?

@martenumberto Since you seem to have the data available, would you mind testing this change?
martenumberto commented 2025-04-20 12:51:49 +00:00 (Migrated from github.com)
Copy Link

Sadly it doesnt work.
It seams that the Newtonsoft JSON Reader hase some problems with it.
Have a look at my PR: 2ad85050c4
I've closed it due to errors when i start playback of an Episode corresponding to the error

The Log with your PR:

[2025-04-20 14:50:44.751 +02:00] [ERR] [27] Jellyfin.Xtream.SeriesChannel: Failed to get channel items
Newtonsoft.Json.JsonReaderException: Could not convert string to DateTime: null. Path 'seasons[0].air_date', line 1, position 165.
at Newtonsoft.Json.JsonReader.ReadDateTimeString(String s)
at Newtonsoft.Json.JsonTextReader.FinishReadQuotedStringValue(ReadType readType)
at Newtonsoft.Json.JsonTextReader.ReadAsDateTime()
at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value)
at Jellyfin.Xtream.Client.XtreamClient.QueryApi[T](ConnectionInfo connectionInfo, String urlPath, CancellationToken cancellationToken)
at Jellyfin.Xtream.Service.StreamService.GetSeasons(Int32 seriesId, CancellationToken cancellationToken)
at Jellyfin.Xtream.SeriesChannel.GetSeasons(Int32 seriesId, CancellationToken cancellationToken)
at Jellyfin.Xtream.SeriesChannel.GetChannelItems(InternalChannelItemQuery query, CancellationToken cancellationToken)

Sadly it doesnt work. It seams that the Newtonsoft JSON Reader hase some problems with it. Have a look at my PR: https://github.com/Kevinjil/Jellyfin.Xtream/pull/174/commits/2ad85050c493f8325067d5b0fc0e67f84d5fb9ca I've closed it due to errors when i start playback of an Episode corresponding to the error The Log with your PR: > [2025-04-20 14:50:44.751 +02:00] [ERR] [27] Jellyfin.Xtream.SeriesChannel: Failed to get channel items Newtonsoft.Json.JsonReaderException: Could not convert string to DateTime: null. Path 'seasons[0].air_date', line 1, position 165. at Newtonsoft.Json.JsonReader.ReadDateTimeString(String s) at Newtonsoft.Json.JsonTextReader.FinishReadQuotedStringValue(ReadType readType) at Newtonsoft.Json.JsonTextReader.ReadAsDateTime() at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent) at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType) at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType) at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings) at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings) at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value) at Jellyfin.Xtream.Client.XtreamClient.QueryApi[T](ConnectionInfo connectionInfo, String urlPath, CancellationToken cancellationToken) at Jellyfin.Xtream.Service.StreamService.GetSeasons(Int32 seriesId, CancellationToken cancellationToken) at Jellyfin.Xtream.SeriesChannel.GetSeasons(Int32 seriesId, CancellationToken cancellationToken) at Jellyfin.Xtream.SeriesChannel.GetChannelItems(InternalChannelItemQuery query, CancellationToken cancellationToken)
Kevinjil commented 2025-05-05 11:41:59 +00:00 (Migrated from github.com)
Copy Link

@martenumberto Re-reading your messages, is the value in the JSON literally a string "null", instead of a null JSON value? If so, could you test this change?

@martenumberto Re-reading your messages, is the value in the JSON literally a string "null", instead of a `null` JSON value? If so, could you test this change?
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/empty-air-date:fix/empty-air-date
git checkout fix/empty-air-date
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
This PR is blocked due to a commented reason
 breaking
This PR introduces breaking changes
 bug
This PR or Issue describes or fixes something that isn't working
 chore
This PR contains repository maintenance changes
 ci
This PR updates or changes something CI related
 confirmed
This Issue describes a bug that has been confirmed by a org member
 dependencies
This PR updates or changes a dependency file
 deprecated
This PR marks a feature, function or other public API element as deprecated
 documentation
This PR or Issue aims to improve or add to documentation
 duplicate
This Issue or PR is a duplicate of an existing Issue or PR
 feature
This PR or Issue requests or introduces a new feature
 github-actions
This PR updates or changes GH Actions used in this repo
 good first issue
This Issue contains a requirement easy to be picked up by project newcomers
 help wanted
This Issue or PR requires extra attention and/or requires external help
 invalid
This Issue describes an invalid request or bug report
 major-bug
This PR fixes a major bug
 major-feature
This PR introduces a major new feature
 nuget
This PR updates or changes some NuGet dependencies
 question
This Issue contains a question
 release-prep
This PR is a meta PR to prepare for the next release
 removed
This PR removes a feature, function or other public API element
 reverted
This PR reverts a commit or multiple commits
 skip-changelog
This PR gets ignored by the Release Drafter workflow
 tests
This PR adds or imposes tests (e.g. coverage, quality, ...)
 wontfix
This Issue contains a request or 'bug' that wont be fixed (e.g. out-of-scope, not-an-issue, ...)
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Sirherobrine23
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sirherobrine23/Jellyfin_Xtream#175
No description provided.
Delete Branch "fix/empty-air-date"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?