Sirherobrine23/Jellyfin_Xtream
1
0
Fork 0
Code Issues 26 Pull Requests 6 Actions Releases Wiki Activity

Solve most code style warnings #149

Merged
Kevinjil merged 1 commits from fix/code-style into master 2025-01-09 17:59:21 +00:00
Conversation 1 Commits 1 Files Changed 17 +309 -560
Kevinjil commented 2025-01-09 17:39:38 +00:00 (Migrated from github.com)
Copy Link

Skipped "Member ... does not access instance data and can be marked as static" when future non-static use is expected.
Skipped some switch statements which will be filled in.

Skipped "Member ... does not access instance data and can be marked as static" when future non-static use is expected. Skipped some switch statements which will be filled in.
github-advanced-security[bot] (Migrated from github.com) reviewed 2025-01-09 17:41:16 +00:00
Jellyfin.Xtream/Plugin.cs
@@ -40,3 +37,4 @@
private static Plugin? _instance;
/// <summary>
/// Initializes a new instance of the <see cref="Plugin"/> class.
github-advanced-security[bot] (Migrated from github.com) commented 2025-01-09 17:41:16 +00:00
Copy Link

Missed 'readonly' opportunity

Field '_instance' can be 'readonly'.

Show more details

## Missed 'readonly' opportunity Field '_instance' can be 'readonly'. [Show more details](https://github.com/Kevinjil/Jellyfin.Xtream/security/code-scanning/128)
Jellyfin.Xtream/Plugin.cs
github-advanced-security[bot] (Migrated from github.com) commented 2025-01-09 17:41:16 +00:00
Copy Link

Static field written by instance method

Write to static field from instance method, property, or constructor.

Show more details

## Static field written by instance method Write to static field from instance method, property, or constructor. [Show more details](https://github.com/Kevinjil/Jellyfin.Xtream/security/code-scanning/127)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
This PR is blocked due to a commented reason
 breaking
This PR introduces breaking changes
 bug
This PR or Issue describes or fixes something that isn't working
 chore
This PR contains repository maintenance changes
 ci
This PR updates or changes something CI related
 confirmed
This Issue describes a bug that has been confirmed by a org member
 dependencies
This PR updates or changes a dependency file
 deprecated
This PR marks a feature, function or other public API element as deprecated
 documentation
This PR or Issue aims to improve or add to documentation
 duplicate
This Issue or PR is a duplicate of an existing Issue or PR
 feature
This PR or Issue requests or introduces a new feature
 github-actions
This PR updates or changes GH Actions used in this repo
 good first issue
This Issue contains a requirement easy to be picked up by project newcomers
 help wanted
This Issue or PR requires extra attention and/or requires external help
 invalid
This Issue describes an invalid request or bug report
 major-bug
This PR fixes a major bug
 major-feature
This PR introduces a major new feature
 nuget
This PR updates or changes some NuGet dependencies
 question
This Issue contains a question
 release-prep
This PR is a meta PR to prepare for the next release
 removed
This PR removes a feature, function or other public API element
 reverted
This PR reverts a commit or multiple commits
 skip-changelog
This PR gets ignored by the Release Drafter workflow
 tests
This PR adds or imposes tests (e.g. coverage, quality, ...)
 wontfix
This Issue contains a request or 'bug' that wont be fixed (e.g. out-of-scope, not-an-issue, ...)
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
Sirherobrine23
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Sirherobrine23/Jellyfin_Xtream#149
No description provided.
Delete Branch "fix/code-style"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?