0
0
mirror of https://github.com/termux/termux-packages.git synced 2025-05-11 08:35:47 +00:00
Files
termux-packages/packages/sbcl/disable-failing-tests-that-were-only-enabled-on-x86.patch
Robert Kirkman ad4b6d61a9 bump(main/sbcl): 2.5.4
- Fixes https://github.com/termux/termux-packages/issues/24526

- The auto update failed to proceed because I put the host SBCL download in `termux_download` instead of `TERMUX_PKG_SRCURL` and I forgot I did that,

- However, there are some changes near areas patched by patch files, so the patches have to be rebased anyway

- `disable-failing-tests-that-were-only-enabled-on-x86.patch`: In b219fb32f5, upstream disabled the failing x86-only test by commenting it out, but in rebasing, I have preserved the hunk to disable it on Android should it ever be enabled again upstream, as a reminder for the future that this test was failing on Android-x86 and might need to remain disabled even if upstream enables it again in the future.

- `pass-testsuite-on-device.patch`: Upstream decided to add a null return check to the implementation of `sb-unix:unix-tmpfile()` as a result of discussion that was, in fact, related to its test failing on Termux shortly prior to the addition of `sbcl` to termux-packages, and that is OK and should not have any major effect on the tests we run here, because of our `termux_tmpfile()` implementation preventing it from returning null in most situations.
2025-05-05 20:03:03 -05:00

33 lines
1.1 KiB
Diff

elfcore.test.sh is not passing on Android-x86,
so it is disabled by this. Upstream also currently has
elf-sans-immobile.test.sh disabled.
These tests also fail on ARM, but were
not enabled by upstream on any targets except 64-bit x86.
The exact reason why the test fails, or what steps might be necessary
to fix it, are not known, but one way of describing the probable
effects that this test failing implies would be:
"the 'elfination' feature is most likely not working on Android"
--- a/tests/elf-sans-immobile.test.sh
+++ b/tests/elf-sans-immobile.test.sh
@@ -16,7 +16,7 @@
. ./subr.sh
run_sbcl <<EOF
-;#+(and linux x86-64 sb-thread)
+;#+(and linux x86-64 sb-thread (not android))
;(unless (member :immobile-space sb-impl:+internal-features+)
; (exit :code 0)) ; proceed with test
(exit :code 2) ; otherwise skip the test
--- a/tests/elfcore.test.sh
+++ b/tests/elfcore.test.sh
@@ -16,7 +16,7 @@
. ./subr.sh
run_sbcl <<EOF
- #+(and linux elf sb-thread)
+ #+(and linux elf sb-thread (not android))
(let ((s (find-symbol "IMMOBILE-SPACE-OBJ-P" "SB-KERNEL")))
(when (and s (funcall s #'car)) (exit :code 0))) ; good
(exit :code 2) ; otherwise