mirror of
https://github.com/tursodatabase/libsql.git
synced 2025-06-11 10:56:47 +00:00
112c72bb8e
* Add regression tests for random rowid bugs Tests added for: 1. VACUUM does not respect RANDOM ROWID - https://github.com/tursodatabase/libsql/issues/929 2. Bulk insert into a fresh table does not respect RANDOM ROWID - https://github.com/tursodatabase/libsql/issues/1046 In both cases, the table should end up random rowids, but they seem to have sequential ones. * bugfix: pass `regNextRowid` to `OP_NewRowid` call in `xferOptimization` The register `regNextRowid` contains the `LIBSQL_RANDOM_ROWID_MARKER` value which tells the VDBE to use a random value for row ids. The method `xferOptimization` is used in `VACUUM` and bulk insert routines where data from one table is inserted in another. Since the data is inserted in a loop, it checks for max rowid once and then keeps inserting it serially. Hence we pass the marker in each call, so that random id is generated.