From 1f0c9df0cb746a019572cf7ff9cd203dc24fc133 Mon Sep 17 00:00:00 2001
From: Lucio Franco <luciofranco14@gmail.com>
Date: Thu, 19 Sep 2024 13:58:18 -0400
Subject: [PATCH] sqld: improve conn.is_primary error message
---
libsql-server/src/rpc/proxy.rs | 4 ++--
libsql-server/tests/cluster/schema_dbs.rs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libsql-server/src/rpc/proxy.rs b/libsql-server/src/rpc/proxy.rs
index ff9d5bac0a..1ab5d1d19a 100644
--- a/libsql-server/src/rpc/proxy.rs
+++ b/libsql-server/src/rpc/proxy.rs
@@ -635,7 +635,7 @@ impl Proxy for ProxyService {
Ok(conn) => {
if !conn.is_primary() {
return Err(tonic::Status::failed_precondition(
- "cannot run schema migration against a replica",
+ "cannot run schema migration against a replica from a replica",
));
}
@@ -710,7 +710,7 @@ impl Proxy for ProxyService {
Ok(conn) => {
if !conn.is_primary() {
return Err(tonic::Status::failed_precondition(
- "cannot run schema migration against a replica",
+ "cannot run schema migration against a replica from a replica",
));
}
diff --git a/libsql-server/tests/cluster/schema_dbs.rs b/libsql-server/tests/cluster/schema_dbs.rs
index 37dc0473d1..e9ab5036cc 100644
--- a/libsql-server/tests/cluster/schema_dbs.rs
+++ b/libsql-server/tests/cluster/schema_dbs.rs
@@ -131,7 +131,7 @@ fn schema_migration_basics() {
}
#[test]
-fn error_on_replicate() {
+fn schema_migration_via_replica() {
let mut sim = Builder::new()
.simulation_duration(Duration::from_secs(1000))
.build();