0
1
mirror of https://github.com/golang/go synced 2025-06-02 16:00:59 +00:00
Files
David Chase 2aaa388971 [release-branch.go1.23] cmd/compile, runtime: use deferreturn as target PC for recover from deferrangefunc
The existing code for recover from deferrangefunc was broken in
several ways.

1. the code following a deferrangefunc call did not check the return
value for an out-of-band value indicating "return now" (i.e., recover
was called)

2. the returned value was delivered using a bespoke ABI that happened
to match on register-ABI platforms, but not on older stack-based
ABI.

3. the returned value was the wrong width (1 word versus 2) and
type/value(integer 1, not a pointer to anything) for deferrangefunc's
any-typed return value (in practice, the OOB value check could catch
this, but still, it's sketchy).

This -- using the deferreturn lookup method already in place for
open-coded defers -- turned out to be a much-less-ugly way of
obtaining the desired transfer of control for recover().

TODO: we also could do this for regular defer, and delete some code.

Fixes 

Change-Id: If7d7ea789ad4320821aab3b443759a7d71647ff0
Reviewed-on: https://go-review.googlesource.com/c/go/+/650476
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/651496
2025-02-21 18:58:07 -08:00
..
2012-02-16 23:48:57 -05:00
2023-03-28 18:13:13 +00:00
2012-02-16 23:49:30 -05:00
2023-03-28 18:13:13 +00:00
2023-03-28 18:13:13 +00:00
2023-03-28 18:13:13 +00:00
2023-03-28 18:13:13 +00:00
2023-03-28 18:13:13 +00:00
2012-02-16 23:49:30 -05:00
2022-05-18 00:47:29 +00:00
2023-03-28 18:13:13 +00:00
2021-02-22 22:53:51 +00:00
2023-04-11 20:56:32 +00:00
2021-04-21 20:24:34 +00:00
2021-02-22 20:00:00 +00:00
2021-05-22 00:51:17 +00:00
2023-02-07 20:59:40 +00:00