Matthew Dempsky
9f8b3ac8c4
[release-branch.go1.21] cmd/compile: fix escape analysis of string min/max
...
When I was plumbing min/max support through the compiler, I was
thinking mostly about numeric argument types. As a result, I forgot
that escape analysis would need to be aware that min/max can operate
on string values, which contain pointers.
Updates #64565 .
Fixes #64567 .
Change-Id: I36127ce5a2da942401910fa0f9de922726c9f94d
Reviewed-on: https://go-review.googlesource.com/c/go/+/547715
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 34416d7f6f93cd6562636e311c362ebe421f1a4c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/547757
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
2023-12-06 21:31:12 +00:00
..
2021-09-17 22:59:44 +00:00
2017-01-20 05:55:53 +00:00
2023-06-16 17:08:43 +00:00
2022-01-10 21:27:19 +00:00
2021-07-14 23:33:46 +00:00
2023-05-22 22:47:15 +00:00
2022-03-24 02:14:15 +00:00
2023-12-06 21:29:58 +00:00
2016-05-02 13:43:18 +00:00
2023-12-06 21:31:12 +00:00
2016-05-02 13:43:18 +00:00
2022-09-27 21:10:19 +00:00
2023-03-28 14:28:33 +00:00
2022-10-18 18:06:27 +00:00
2021-12-05 12:50:44 +00:00
2022-03-24 17:50:47 +00:00
2014-01-07 13:26:48 +01:00
2021-12-13 22:42:08 +00:00
2019-08-28 19:27:20 +00:00
2021-04-05 17:51:15 +00:00
2022-09-01 22:37:04 +00:00
2023-05-25 21:37:01 +00:00
2016-07-06 20:48:41 +00:00
2016-04-24 21:36:52 +00:00
2016-05-02 13:43:18 +00:00
2022-09-28 22:28:39 +00:00
2017-01-20 05:55:53 +00:00
2016-05-02 13:43:18 +00:00
2018-04-09 18:57:37 +00:00
2022-09-28 22:28:39 +00:00
2018-05-06 04:28:23 +00:00
2017-05-11 13:53:54 +00:00
2021-10-30 18:30:05 +00:00
2020-12-14 12:13:36 -08:00
2016-03-17 04:20:02 +00:00
2020-12-14 12:13:36 -08:00
2013-10-08 14:36:20 -04:00
2016-05-02 13:43:18 +00:00
2020-10-27 03:11:45 +00:00
2020-12-01 21:49:31 +00:00
2021-01-05 21:44:30 +00:00
2020-03-29 17:12:56 +00:00
2021-03-05 18:46:43 +00:00
2023-05-24 14:39:34 +00:00
2023-01-31 19:43:07 +00:00
2014-10-31 11:08:27 -04:00
2015-01-29 13:07:30 +00:00
2023-03-06 18:34:24 +00:00
2021-02-24 21:34:21 +00:00
2018-08-14 09:19:38 +00:00
2021-01-20 22:53:32 +00:00
2021-01-23 02:15:24 +00:00
2021-02-01 18:28:05 +00:00
2020-12-01 21:49:31 +00:00
2015-06-26 03:38:21 +00:00
2019-03-14 21:00:20 +00:00
2017-03-15 22:45:17 +00:00
2017-03-15 22:45:17 +00:00
2017-03-15 22:45:17 +00:00
2021-06-02 05:14:45 +00:00
2016-05-02 13:43:18 +00:00
2020-12-01 21:49:31 +00:00
2020-12-01 21:49:31 +00:00
2015-07-11 14:36:33 +00:00
2015-07-11 14:36:33 +00:00
2016-05-02 13:43:18 +00:00
2023-04-11 20:56:32 +00:00
2022-06-28 18:11:31 +00:00
2019-09-26 23:54:29 +00:00
2016-05-02 13:43:18 +00:00
2022-09-08 15:55:44 +00:00
2022-09-19 18:58:26 +00:00
2022-11-17 13:46:05 +00:00
2021-03-23 05:11:09 +00:00
2020-12-04 21:22:23 +00:00
2022-09-28 22:28:39 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2021-06-14 07:12:37 +00:00
2020-02-26 16:54:17 +00:00
2021-01-05 21:11:31 +00:00
2019-10-16 00:05:37 +00:00
2018-05-31 17:36:45 +00:00
2021-08-09 16:10:20 +00:00
2022-09-02 06:22:23 +00:00
2022-09-02 06:22:23 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2021-01-19 20:07:52 +00:00
2021-01-19 20:07:52 +00:00
2023-05-12 12:34:59 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2021-06-23 16:48:12 +00:00
2021-06-23 16:48:12 +00:00
2016-05-02 13:43:18 +00:00
2023-01-31 20:36:55 +00:00
2021-07-28 21:41:07 +00:00
2021-05-26 23:50:32 +00:00
2023-12-06 21:31:12 +00:00
2021-05-26 23:50:32 +00:00
2020-09-12 08:31:49 +00:00
2021-07-28 21:41:07 +00:00
2019-11-16 20:31:45 +00:00
2023-05-23 17:16:35 +00:00
2020-09-12 08:31:49 +00:00
2019-09-03 17:52:06 +00:00
2020-09-12 08:31:49 +00:00
2021-05-26 23:50:32 +00:00
2023-05-12 23:13:19 +00:00
2021-05-26 23:50:32 +00:00
2019-04-17 16:36:56 +00:00
2022-09-19 18:58:26 +00:00
2020-09-12 08:31:49 +00:00
2020-09-12 08:31:49 +00:00
2021-05-26 23:50:32 +00:00
2019-04-17 19:09:15 +00:00
2022-09-07 17:25:59 +00:00
2023-03-06 18:34:24 +00:00
2014-12-08 22:22:58 +00:00
2019-09-08 17:28:20 +00:00
2016-09-14 16:39:47 +00:00
2021-12-03 16:24:32 +00:00
2023-07-10 16:36:41 +00:00
2020-12-04 21:22:23 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-12-04 21:22:23 +00:00
2020-12-04 21:22:23 +00:00
2021-04-28 15:55:10 +00:00
2018-04-30 19:39:18 +00:00
2018-05-08 21:15:48 +00:00
2016-05-02 13:43:18 +00:00
2019-10-10 19:38:06 +00:00
2017-04-19 02:27:58 +00:00
2022-05-27 21:36:06 +00:00
2018-05-31 17:36:45 +00:00
2022-09-27 21:10:19 +00:00
2016-05-02 13:43:18 +00:00
2017-03-24 20:07:15 +00:00
2022-01-11 02:26:58 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2019-09-08 17:28:20 +00:00
2016-05-02 13:43:18 +00:00
2020-12-14 12:13:36 -08:00
2022-09-23 20:27:09 +00:00
2022-11-16 04:04:52 +00:00
2022-01-11 02:26:58 +00:00
2020-12-09 23:56:19 +00:00
2023-01-24 13:28:54 +00:00
2019-01-08 21:54:04 +00:00
2019-01-08 21:54:04 +00:00
2022-09-15 21:05:02 +00:00
2017-03-03 21:29:32 +00:00
2018-08-30 22:48:28 +00:00
2023-05-12 21:11:51 +00:00
2021-05-26 23:50:45 +00:00
2023-05-23 17:16:35 +00:00
2022-05-20 16:16:37 +00:00
2016-09-19 19:03:01 +00:00
2020-11-28 02:31:54 +00:00
2020-11-28 02:31:54 +00:00
2023-04-11 20:56:32 +00:00
2016-05-02 13:43:18 +00:00
2021-12-03 16:24:32 +00:00
2019-08-28 19:27:20 +00:00
2023-04-11 20:56:32 +00:00
2023-04-11 20:56:32 +00:00
2019-11-01 20:13:05 +00:00
2019-02-19 22:45:09 +00:00
2016-05-02 13:43:18 +00:00
2019-09-03 19:33:04 +00:00
2023-01-21 21:08:30 +00:00
2023-04-11 20:56:32 +00:00
2023-01-21 21:08:00 +00:00
2023-05-24 14:39:34 +00:00
2020-12-17 04:43:46 +00:00
2021-04-23 00:41:01 +00:00
2021-04-23 00:41:01 +00:00
2020-12-04 21:22:23 +00:00
2020-05-07 17:50:24 +00:00
2020-12-14 12:13:36 -08:00
2014-08-06 17:02:55 -04:00
2018-05-08 21:15:16 +00:00
2014-10-27 18:59:02 -04:00
2021-11-05 00:52:06 +00:00
2017-09-03 14:29:38 +00:00
2022-09-27 21:59:19 +00:00
2022-01-10 22:48:40 +00:00
2016-05-02 13:43:18 +00:00
2020-12-04 21:22:23 +00:00
2021-01-26 17:05:06 +00:00
2020-12-04 21:22:23 +00:00
2016-05-02 13:43:18 +00:00
2022-06-30 18:41:59 +00:00
2019-05-11 03:02:33 +00:00
2023-03-29 21:55:11 +00:00
2016-05-02 13:43:18 +00:00
2018-11-27 15:36:08 +00:00
2018-11-26 14:13:53 +00:00
2022-08-23 19:56:32 +00:00
2018-11-26 14:13:53 +00:00
2021-02-19 00:40:22 +00:00
2023-04-14 17:57:36 +00:00
2023-04-21 19:28:56 +00:00
2020-04-03 21:43:52 +00:00
2016-10-25 22:28:40 +00:00
2019-09-08 17:28:20 +00:00
2018-04-30 19:39:18 +00:00
2021-03-29 05:50:11 +00:00
2018-05-31 17:36:45 +00:00
2017-09-26 04:08:38 +00:00
2018-05-31 17:36:45 +00:00
2022-05-04 20:30:17 +00:00
2023-04-10 17:13:41 +00:00
2017-09-12 05:50:54 +00:00
2023-05-12 17:18:08 +00:00
2016-05-02 13:43:18 +00:00
2019-09-03 20:41:29 +00:00
2016-05-02 13:43:18 +00:00
2021-11-12 16:58:34 +00:00
2017-04-24 12:37:49 +00:00
2016-05-02 13:43:18 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 21:19:20 +00:00
2016-03-11 22:07:02 +00:00
2020-04-19 03:12:32 +00:00
2020-04-19 03:12:32 +00:00
2021-10-26 14:24:17 +00:00
2021-07-22 17:48:41 +00:00
2023-04-19 14:07:00 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2021-01-16 23:19:26 +00:00
2018-03-01 21:11:16 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-12-09 23:56:19 +00:00
2021-12-03 16:24:32 +00:00
2016-05-02 13:43:18 +00:00
2022-04-07 17:19:55 +00:00
2023-04-11 20:56:32 +00:00
2016-05-02 13:43:18 +00:00
2016-05-02 13:43:18 +00:00
2020-12-14 21:28:48 +00:00
2016-05-02 13:43:18 +00:00
2018-03-08 22:25:25 +00:00
2018-10-03 19:54:29 +00:00
2018-10-03 19:54:16 +00:00
2018-10-03 19:54:16 +00:00
2018-06-12 19:10:34 +00:00
2019-09-08 17:28:20 +00:00
2013-12-12 17:17:02 -08:00
2016-05-02 13:43:18 +00:00
2022-09-01 22:37:04 +00:00
2020-12-15 19:43:32 +00:00
2020-12-14 21:28:48 +00:00
2022-09-24 17:04:15 +00:00
2020-12-14 21:28:48 +00:00
2022-07-19 23:30:49 +00:00
2023-05-16 01:01:38 +00:00
2015-11-03 18:57:18 +00:00
2014-07-01 09:20:51 +02:00
2022-01-11 02:26:58 +00:00
2022-09-23 20:27:09 +00:00
2019-09-11 23:33:11 +00:00
2022-09-27 21:10:19 +00:00
2021-11-12 22:20:51 +00:00
2021-06-24 18:24:24 +00:00
2019-11-05 00:26:30 +00:00
2016-07-06 20:48:41 +00:00
2022-04-21 18:06:38 +00:00
2016-05-02 13:43:18 +00:00
2022-08-31 17:15:15 +00:00
2022-08-31 17:15:15 +00:00
2022-08-31 17:15:15 +00:00
2022-08-31 17:15:15 +00:00
2020-12-28 00:39:17 -08:00
2020-12-04 21:22:23 +00:00
2020-12-02 16:33:57 +00:00
2021-08-23 19:46:36 +00:00
2021-10-06 15:53:04 +00:00
2023-04-28 18:35:43 +00:00