mirror of
https://github.com/golang/go
synced 2025-04-10 00:14:38 +00:00
e6130c66c8
This CL changes the inliner to process transitive inlining iteratively after the AST has actually been edited, rather than recursively and immediately. This is important for handling indirect function calls correctly, because ir.reassigned walks the function body looking for reassignments; whereas previously the inlined reassignments might not have been actually added to the AST yet. Fixes #59158. This change was previously reverted as CL 481796 because the branch was frozen for release. Change-Id: I97fcd32956cc1349d87a92066e8559cb90da73b7 Reviewed-on: https://go-review.googlesource.com/c/go/+/481797 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
32 lines
609 B
Go
32 lines
609 B
Go
// run
|
|
|
|
// Copyright 2022 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// The inliner would erroneously scan the caller function's body for
|
|
// reassignments *before* substituting the inlined function call body,
|
|
// which could cause false positives in deciding when it's safe to
|
|
// transitively inline indirect function calls.
|
|
|
|
package main
|
|
|
|
func main() {
|
|
bug1()
|
|
bug2(fail)
|
|
}
|
|
|
|
func bug1() {
|
|
fn := fail
|
|
fn = pass
|
|
fn()
|
|
}
|
|
|
|
func bug2(fn func()) {
|
|
fn = pass
|
|
fn()
|
|
}
|
|
|
|
func pass() {}
|
|
func fail() { panic("FAIL") }
|