0
1
mirror of https://github.com/golang/go synced 2025-04-15 00:35:44 +00:00
Files
Cuong Manh Le 11033eac90 [release-branch.go1.19] cmd/compile: only inline method wrapper if method don't contain closures
CL 327871 changes methodWrapper to always perform inlining after global
escape analysis. However, inlining the method may reveal closures, which
require walking all function bodies to decide whether to capture free
variables by value or by ref.

To fix it, just not doing inline if the method contains any closures.

Fixes 

Change-Id: I4b0255b86257cc6fe7e5fafbc545cc5cff9113e1
Reviewed-on: https://go-review.googlesource.com/c/go/+/426334
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/426160
2022-08-31 16:23:03 +00:00

40 lines
551 B
Go

// run
// Copyright 2022 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
type Elem struct{}
func (*Elem) Wait(callback func()) {}
type Base struct {
elem [8]*Elem
}
var g_val = 1
func (s *Base) Do() *int {
resp := &g_val
for _, e := range s.elem {
e.Wait(func() {
*resp = 0
})
}
return resp
}
type Sub struct {
*Base
}
func main() {
a := Sub{new(Base)}
resp := a.Do()
if resp != nil && *resp != 1 {
panic("FAIL")
}
}