mirror of
https://github.com/golang/go
synced 2025-06-10 16:55:44 +00:00
1aa3362093
This reverts CL 650455 and CL 655816. Reason for revert: it causes #73747. Properly fixing it gets into trickiness with defer/recover, wrapper, and inlining. We're late in the Go 1.25 release cycle. Fixes #73747. Change-Id: Ifb343d522b18fec3fec73a7c886678032ac8e4df Reviewed-on: https://go-review.googlesource.com/c/go/+/678575 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
30 lines
805 B
Go
30 lines
805 B
Go
// errorcheck -0 -d=tailcall=1
|
|
|
|
// Copyright 2024 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package p
|
|
|
|
// Test that when generating wrappers for methods, we generate a tail call to the pointer version of
|
|
// the method, if that method is not inlineable. We use go:noinline here to force the non-inlineability
|
|
// condition.
|
|
|
|
//go:noinline
|
|
func (f *Foo) Get2Vals() [2]int { return [2]int{f.Val, f.Val + 1} }
|
|
func (f *Foo) Get3Vals() [3]int { return [3]int{f.Val, f.Val + 1, f.Val + 2} }
|
|
|
|
type Foo struct{ Val int }
|
|
|
|
type Bar struct { // ERROR "tail call emitted for the method \(\*Foo\).Get2Vals wrapper"
|
|
int64
|
|
*Foo // needs a method wrapper
|
|
string
|
|
}
|
|
|
|
var i any
|
|
|
|
func init() {
|
|
i = Bar{1, nil, "first"}
|
|
}
|