mirror of
https://github.com/golang/go
synced 2025-02-23 03:56:14 +00:00
44a6f817ea
We can't coalesce a non-WB store with a subsequent Move, as the result of the store might be the source of the move. There's a simple codegen test. Not sure how we might do a real test, as all the repro's I've come up with are very expensive and unreliable. Fixes #71228 Change-Id: If18bf181a266b9b90964e2591cd2e61a7168371c Reviewed-on: https://go-review.googlesource.com/c/go/+/642197 Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
91 lines
2.3 KiB
Go
91 lines
2.3 KiB
Go
// asmcheck
|
|
|
|
// Copyright 2023 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package codegen
|
|
|
|
func combine2string(p *[2]string, a, b string) {
|
|
// amd64:`.*runtime[.]gcWriteBarrier4\(SB\)`
|
|
// arm64:`.*runtime[.]gcWriteBarrier4\(SB\)`
|
|
p[0] = a
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[1] = b
|
|
}
|
|
|
|
func combine4string(p *[4]string, a, b, c, d string) {
|
|
// amd64:`.*runtime[.]gcWriteBarrier8\(SB\)`
|
|
// arm64:`.*runtime[.]gcWriteBarrier8\(SB\)`
|
|
p[0] = a
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[1] = b
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[2] = c
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[3] = d
|
|
}
|
|
|
|
func combine2slice(p *[2][]byte, a, b []byte) {
|
|
// amd64:`.*runtime[.]gcWriteBarrier4\(SB\)`
|
|
// arm64:`.*runtime[.]gcWriteBarrier4\(SB\)`
|
|
p[0] = a
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[1] = b
|
|
}
|
|
|
|
func combine4slice(p *[4][]byte, a, b, c, d []byte) {
|
|
// amd64:`.*runtime[.]gcWriteBarrier8\(SB\)`
|
|
// arm64:`.*runtime[.]gcWriteBarrier8\(SB\)`
|
|
p[0] = a
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[1] = b
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[2] = c
|
|
// amd64:-`.*runtime[.]gcWriteBarrier`
|
|
// arm64:-`.*runtime[.]gcWriteBarrier`
|
|
p[3] = d
|
|
}
|
|
|
|
func trickyWriteNil(p *int, q **int) {
|
|
if p == nil {
|
|
// We change "= p" to "= 0" in the prove pass, which
|
|
// means we have one less pointer that needs to go
|
|
// into the write barrier buffer.
|
|
// amd64:`.*runtime[.]gcWriteBarrier1`
|
|
*q = p
|
|
}
|
|
}
|
|
|
|
type S struct {
|
|
a, b string
|
|
c *int
|
|
}
|
|
|
|
var g1, g2 *int
|
|
|
|
func issue71228(dst *S, ptr *int) {
|
|
// Make sure that the non-write-barrier write.
|
|
// "sp.c = ptr" happens before the large write
|
|
// barrier "*dst = *sp". We approximate testing
|
|
// that by ensuring that two global variable write
|
|
// barriers aren't combined.
|
|
_ = *dst
|
|
var s S
|
|
sp := &s
|
|
//amd64:`.*runtime[.]gcWriteBarrier1`
|
|
g1 = nil
|
|
sp.c = ptr // outside of any write barrier
|
|
//amd64:`.*runtime[.]gcWriteBarrier1`
|
|
g2 = nil
|
|
//amd64:`.*runtime[.]wbMove`
|
|
*dst = *sp
|
|
}
|