mirror of
https://github.com/golang/go
synced 2025-07-07 20:35:21 +00:00
988a20c8c5
CL 649035 and CL 649079 updated escape analysis to rewrite certain operands in OMAKE and OCONVIFACE nodes from non-constant expressions to basic literals that evaluate to the same value. However, when doing that rewriting, we need to evaluate any side effects prior to replacing the expression, which is what this CL now does. Issue #74379 reported a problem with OCONVIFACE nodes due to CL 649079. CL 649035 has essentially the same issue with OMAKE nodes. To illustrate that, we add a test for the OMAKE case in fixedbugs/issue74379b.go, which fails without this change. To avoid introducing an unnecessary temporary for OMAKE nodes, we also conditionalize the main work of CL 649035 on whether the OMAKE operand is already an OLITERAL. CL 649555 and CL 649078 were related changes that created read-only global storage for composite literals used in an interface conversion. This CL adds a test in fixedbugs/issue74379c.go to illustrate that they do not have the same problem. Updates #71359 Fixes #74379 Change-Id: I6645575ef34f1fe2b0241a22dc205875d66b7ada Reviewed-on: https://go-review.googlesource.com/c/go/+/684116 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Keith Randall <khr@google.com>
55 lines
838 B
Go
55 lines
838 B
Go
// run
|
|
|
|
// Copyright 2025 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
)
|
|
|
|
type S struct{ a, b int }
|
|
|
|
func crashOnErr1(err error) S {
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return S{} // zero value struct
|
|
}
|
|
|
|
func f1() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
fmt.Println("failed to have expected panic")
|
|
os.Exit(1)
|
|
}
|
|
}()
|
|
fmt.Println(crashOnErr1(errors.New("test error")))
|
|
}
|
|
|
|
func crashOnErr2(err error) S {
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
return S{1, 2} // not zero value struct
|
|
}
|
|
|
|
func f2() {
|
|
defer func() {
|
|
if recover() == nil {
|
|
fmt.Println("failed to have expected panic")
|
|
os.Exit(1)
|
|
}
|
|
}()
|
|
fmt.Println(crashOnErr2(errors.New("test error")))
|
|
}
|
|
|
|
func main() {
|
|
f1()
|
|
f2()
|
|
}
|