0
1
mirror of https://github.com/golang/go synced 2025-05-23 05:58:00 +00:00

cmd/compile: keep variables alive in testing.B.Loop loops

For the loop body guarded by testing.B.Loop, we disable function inlining and devirtualization inside. The only legal form to be matched is `for b.Loop() {...}`.

For 

Change-Id: I2e226f08cb4614667cbded498a7821dffe3f72d8
Reviewed-on: https://go-review.googlesource.com/c/go/+/612043
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Bypass: Junyang Shao <shaojunyang@google.com>
Commit-Queue: Junyang Shao <shaojunyang@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This commit is contained in:
sunnymilk
2024-09-10 12:27:55 -04:00
committed by Go LUCI
parent 73ac82f990
commit fe2da30cb5
2 changed files with 65 additions and 0 deletions
src/cmd/compile/internal/inline/interleaved
test

@ -0,0 +1,31 @@
// errorcheck -0 -m=2
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Test no inlining of function calls in testing.B.Loop.
// See issue #61515.
package foo
import "testing"
func caninline(x int) int { // ERROR "can inline caninline"
return x
}
func cannotinline(b *testing.B) { // ERROR "b does not escape" "cannot inline cannotinline.*"
for i := 0; i < b.N; i++ {
caninline(1) // ERROR "inlining call to caninline"
}
for b.Loop() { // ERROR "skip inlining within testing.B.loop"
caninline(1)
}
for i := 0; i < b.N; i++ {
caninline(1) // ERROR "inlining call to caninline"
}
for b.Loop() { // ERROR "skip inlining within testing.B.loop"
caninline(1)
}
}