golang/go
0
1
Fork 0
mirror of https://github.com/golang/go synced 2025-05-10 04:05:10 +00:00
Code Packages Activity

[dev.typeparams] cmd/compile: make types2 report better error for invalid untyped operation

Browse Source 
This ports the fix in CL 328050 for typecheck to types2.

The fix is not identical, due to code structure differences between
typecheck and types2, but the idea is the same. We only do the untyped
conversion when both operands can be mixed.

Updates 

Change-Id: Ib2c63ba0d5dd8bf02318b1bfdfe51dcaeeeb7f82
Reviewed-on: https://go-review.googlesource.com/c/go/+/328053
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Cuong Manh Le
2021-06-16 16:23:44 +07:00
parent 8115ae198d
commit b14fd720a8
11 changed files with 45 additions and 32 deletions

10
test/fixedbugs/issue46749.go

@ -14,13 +14,13 @@ var iface interface{}
var (
_ = "" + b // ERROR "invalid operation.*mismatched types.*untyped string and bool"
_ = "" + i // ERROR "invalid operation.*mismatched types.*untyped string and int"
_ = "" + nil // ERROR "invalid operation.*mismatched types.*untyped string and nil"
_ = "" + nil // ERROR "invalid operation.*mismatched types.*untyped string and nil|(untyped nil)"
)
var (
_ = s + false // ERROR "invalid operation.*mismatched types.*string and untyped bool"
_ = s + 1 // ERROR "invalid operation.*mismatched types.*string and untyped int"
_ = s + nil // ERROR "invalid operation.*mismatched types.*string and nil"
_ = s + nil // ERROR "invalid operation.*mismatched types.*string and nil|(untyped nil)"
)
var (
@ -31,7 +31,7 @@ var (
var (
_ = b + 1 // ERROR "invalid operation.*mismatched types.*bool and untyped int"
_ = i + false // ERROR "invalid operation.*mismatched types.*int and untyped bool"
_ = iface + 1 // ERROR "invalid operation.*mismatched types.*interface {} and int"
_ = iface + 1.0 // ERROR "invalid operation.*mismatched types.*interface {} and float64"
_ = iface + false // ERROR "invalid operation.*mismatched types.*interface {} and bool"
_ = iface + 1 // ERROR "invalid operation.*mismatched types.*interface *{} and int"
_ = iface + 1.0 // ERROR "invalid operation.*mismatched types.*interface *{} and float64"
_ = iface + false // ERROR "invalid operation.*mismatched types.*interface *{} and bool"
)