forked from Openwrt-EcoNet/openwrt
53c723246a
This is needed to restore compatibility with legacy brcmnand controllers. 3bfb22cecfe6 mtd: rawnand: brcmnand: legacy exec_op implementation 528b541b71cf mtd: nand: brcmnand: fix NAND timeout when accessing eMMC 56fce7547004 mtd: rawnand: brcmnand: remove unused parameters Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
89 lines
3.1 KiB
Diff
89 lines
3.1 KiB
Diff
From 56fce75470041b5b0d92ae10637416e1a4cceb1b Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= <noltari@gmail.com>
|
|
Date: Wed, 14 May 2025 08:14:54 +0200
|
|
Subject: [PATCH] mtd: rawnand: brcmnand: remove unused parameters
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
last_cmd and last_byte are now unused brcmnand_host members.
|
|
last_addr is only written and never read so we can remove it too.
|
|
|
|
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
|
|
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
|
|
Reviewed-by: William Zhang <william.zhang@broadcom.com>
|
|
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
|
|
---
|
|
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 24 ++++++------------------
|
|
1 file changed, 6 insertions(+), 18 deletions(-)
|
|
|
|
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
|
|
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
|
|
@@ -310,9 +310,6 @@ struct brcmnand_host {
|
|
struct platform_device *pdev;
|
|
int cs;
|
|
|
|
- unsigned int last_cmd;
|
|
- unsigned int last_byte;
|
|
- u64 last_addr;
|
|
struct brcmnand_cfg hwcfg;
|
|
struct brcmnand_controller *ctrl;
|
|
};
|
|
@@ -2233,14 +2230,11 @@ static int brcmnand_read_page(struct nan
|
|
int oob_required, int page)
|
|
{
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
|
- struct brcmnand_host *host = nand_get_controller_data(chip);
|
|
u8 *oob = oob_required ? (u8 *)chip->oob_poi : NULL;
|
|
u64 addr = (u64)page << chip->page_shift;
|
|
|
|
- host->last_addr = addr;
|
|
-
|
|
- return brcmnand_read(mtd, chip, host->last_addr,
|
|
- mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
|
|
+ return brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
|
|
+ (u32 *)buf, oob);
|
|
}
|
|
|
|
static int brcmnand_read_page_raw(struct nand_chip *chip, uint8_t *buf,
|
|
@@ -2252,11 +2246,9 @@ static int brcmnand_read_page_raw(struct
|
|
int ret;
|
|
u64 addr = (u64)page << chip->page_shift;
|
|
|
|
- host->last_addr = addr;
|
|
-
|
|
brcmnand_set_ecc_enabled(host, 0);
|
|
- ret = brcmnand_read(mtd, chip, host->last_addr,
|
|
- mtd->writesize >> FC_SHIFT, (u32 *)buf, oob);
|
|
+ ret = brcmnand_read(mtd, chip, addr, mtd->writesize >> FC_SHIFT,
|
|
+ (u32 *)buf, oob);
|
|
brcmnand_set_ecc_enabled(host, 1);
|
|
return ret;
|
|
}
|
|
@@ -2363,13 +2355,10 @@ static int brcmnand_write_page(struct na
|
|
int oob_required, int page)
|
|
{
|
|
struct mtd_info *mtd = nand_to_mtd(chip);
|
|
- struct brcmnand_host *host = nand_get_controller_data(chip);
|
|
void *oob = oob_required ? chip->oob_poi : NULL;
|
|
u64 addr = (u64)page << chip->page_shift;
|
|
|
|
- host->last_addr = addr;
|
|
-
|
|
- return brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
|
|
+ return brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
|
|
}
|
|
|
|
static int brcmnand_write_page_raw(struct nand_chip *chip, const uint8_t *buf,
|
|
@@ -2381,9 +2370,8 @@ static int brcmnand_write_page_raw(struc
|
|
u64 addr = (u64)page << chip->page_shift;
|
|
int ret = 0;
|
|
|
|
- host->last_addr = addr;
|
|
brcmnand_set_ecc_enabled(host, 0);
|
|
- ret = brcmnand_write(mtd, chip, host->last_addr, (const u32 *)buf, oob);
|
|
+ ret = brcmnand_write(mtd, chip, addr, (const u32 *)buf, oob);
|
|
brcmnand_set_ecc_enabled(host, 1);
|
|
|
|
return ret;
|