forked from Openwrt/openwrt
0eeba04a16
7a3bcd39ae1f r8169: use helper r8169_mod_reg8_cond to simplify rtl_jumbo_config e3e9e9039fa6 r8169: align WAKE_PHY handling with r8125/r8126 vendor drivers 330dc2297c82 r8169: improve rtl_set_d3_pll_down c507e96b5763 r8169: improve __rtl8169_set_wol 83cb4b470c66 r8169: remove leftover locks after reverted change 2cd02f2fdd8a r8169: improve initialization of RSS registers on RTL8125/RTL8126 a3d8520e6a19 r8169: align RTL8126 EEE config with vendor driver 4af2f60bf737 r8169: align RTL8125/RTL8126 PHY config with vendor driver eb90f876b796 r8169: align RTL8125 EEE config with vendor driver b8bd8c44a266 r8169: fix inconsistent indenting in rtl8169_get_eth_mac_stats f75d1fbe7809 r8169: add support for RTL8125D c4e64095c00c r8169: enable EEE at 2.5G per default on RTL8125B d64113c6bb5e r8169: remove rtl_dash_loop_wait_high/low 1c105bacb160 r8169: avoid duplicated messages if loading firmware fails and switch to warn level ac48430368c1 r8169: don't take RTNL lock in rtl_task() e3fc5139bd8f r8169: implement additional ethtool stats ops b8bf38440ba9 r8169: enable SG/TSO on selected chip versions per default 854d71c555df r8169: remove original workaround for RTL8125 broken rx issue 1ffcc8d41306 r8169: add support for the temperature sensor being available from RTL8125B The following patches require backporting additional linux patches: e2015942e90a r8169: replace custom flag with disable_work() et al e340bff27e63 r8169: copy vendor driver 2.5G/5G EEE advertisement constraints Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
118 lines
3.5 KiB
Diff
118 lines
3.5 KiB
Diff
From 7a3bcd39ae1f0e3ab896d9df62339ab4297a0bfd Mon Sep 17 00:00:00 2001
|
|
From: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Date: Sat, 9 Nov 2024 23:12:12 +0100
|
|
Subject: [PATCH] r8169: use helper r8169_mod_reg8_cond to simplify
|
|
rtl_jumbo_config
|
|
|
|
Use recently added helper r8169_mod_reg8_cond() to simplify jumbo
|
|
mode configuration.
|
|
|
|
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Reviewed-by: Simon Horman <horms@kernel.org>
|
|
Link: https://patch.msgid.link/3df1d484-a02e-46e7-8f75-db5b428e422e@gmail.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/ethernet/realtek/r8169_main.c | 77 ++++-------------------
|
|
1 file changed, 11 insertions(+), 66 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/realtek/r8169_main.c
|
|
+++ b/drivers/net/ethernet/realtek/r8169_main.c
|
|
@@ -2547,86 +2547,31 @@ static void rtl8169_init_ring_indexes(st
|
|
tp->dirty_tx = tp->cur_tx = tp->cur_rx = 0;
|
|
}
|
|
|
|
-static void r8168c_hw_jumbo_enable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0);
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) | Jumbo_En1);
|
|
-}
|
|
-
|
|
-static void r8168c_hw_jumbo_disable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0);
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~Jumbo_En1);
|
|
-}
|
|
-
|
|
-static void r8168dp_hw_jumbo_enable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0);
|
|
-}
|
|
-
|
|
-static void r8168dp_hw_jumbo_disable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0);
|
|
-}
|
|
-
|
|
-static void r8168e_hw_jumbo_enable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, MaxTxPacketSize, 0x24);
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) | Jumbo_En0);
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) | 0x01);
|
|
-}
|
|
-
|
|
-static void r8168e_hw_jumbo_disable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, MaxTxPacketSize, 0x3f);
|
|
- RTL_W8(tp, Config3, RTL_R8(tp, Config3) & ~Jumbo_En0);
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~0x01);
|
|
-}
|
|
-
|
|
-static void r8168b_1_hw_jumbo_enable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) | (1 << 0));
|
|
-}
|
|
-
|
|
-static void r8168b_1_hw_jumbo_disable(struct rtl8169_private *tp)
|
|
-{
|
|
- RTL_W8(tp, Config4, RTL_R8(tp, Config4) & ~(1 << 0));
|
|
-}
|
|
-
|
|
static void rtl_jumbo_config(struct rtl8169_private *tp)
|
|
{
|
|
bool jumbo = tp->dev->mtu > ETH_DATA_LEN;
|
|
int readrq = 4096;
|
|
|
|
+ if (jumbo && tp->mac_version >= RTL_GIGA_MAC_VER_17 &&
|
|
+ tp->mac_version <= RTL_GIGA_MAC_VER_26)
|
|
+ readrq = 512;
|
|
+
|
|
rtl_unlock_config_regs(tp);
|
|
switch (tp->mac_version) {
|
|
case RTL_GIGA_MAC_VER_17:
|
|
- if (jumbo) {
|
|
- readrq = 512;
|
|
- r8168b_1_hw_jumbo_enable(tp);
|
|
- } else {
|
|
- r8168b_1_hw_jumbo_disable(tp);
|
|
- }
|
|
+ r8169_mod_reg8_cond(tp, Config4, BIT(0), jumbo);
|
|
break;
|
|
case RTL_GIGA_MAC_VER_18 ... RTL_GIGA_MAC_VER_26:
|
|
- if (jumbo) {
|
|
- readrq = 512;
|
|
- r8168c_hw_jumbo_enable(tp);
|
|
- } else {
|
|
- r8168c_hw_jumbo_disable(tp);
|
|
- }
|
|
+ r8169_mod_reg8_cond(tp, Config3, Jumbo_En0, jumbo);
|
|
+ r8169_mod_reg8_cond(tp, Config4, Jumbo_En1, jumbo);
|
|
break;
|
|
case RTL_GIGA_MAC_VER_28:
|
|
- if (jumbo)
|
|
- r8168dp_hw_jumbo_enable(tp);
|
|
- else
|
|
- r8168dp_hw_jumbo_disable(tp);
|
|
+ r8169_mod_reg8_cond(tp, Config3, Jumbo_En0, jumbo);
|
|
break;
|
|
case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33:
|
|
- if (jumbo)
|
|
- r8168e_hw_jumbo_enable(tp);
|
|
- else
|
|
- r8168e_hw_jumbo_disable(tp);
|
|
+ RTL_W8(tp, MaxTxPacketSize, jumbo ? 0x24 : 0x3f);
|
|
+ r8169_mod_reg8_cond(tp, Config3, Jumbo_En0, jumbo);
|
|
+ r8169_mod_reg8_cond(tp, Config4, BIT(0), jumbo);
|
|
break;
|
|
default:
|
|
break;
|