86 lines
2.3 KiB
Diff
86 lines
2.3 KiB
Diff
--- a/src/ap/hostapd.c
|
|
+++ b/src/ap/hostapd.c
|
|
@@ -1103,13 +1103,8 @@ int hostapd_setup_interface_complete(str
|
|
size_t j;
|
|
u8 *prev_addr;
|
|
|
|
- if (err) {
|
|
- wpa_printf(MSG_ERROR, "Interface initialization failed");
|
|
- hostapd_set_state(iface, HAPD_IFACE_DISABLED);
|
|
- if (iface->interfaces && iface->interfaces->terminate_on_error)
|
|
- eloop_terminate();
|
|
- return -1;
|
|
- }
|
|
+ if (err)
|
|
+ goto error;
|
|
|
|
wpa_printf(MSG_DEBUG, "Completing interface initialization");
|
|
if (iface->conf->channel) {
|
|
@@ -1140,7 +1135,7 @@ int hostapd_setup_interface_complete(str
|
|
hapd->iconf->vht_oper_centr_freq_seg1_idx)) {
|
|
wpa_printf(MSG_ERROR, "Could not set channel for "
|
|
"kernel driver");
|
|
- return -1;
|
|
+ goto error;
|
|
}
|
|
}
|
|
|
|
@@ -1151,7 +1146,7 @@ int hostapd_setup_interface_complete(str
|
|
hostapd_logger(hapd, NULL, HOSTAPD_MODULE_IEEE80211,
|
|
HOSTAPD_LEVEL_WARNING,
|
|
"Failed to prepare rates table.");
|
|
- return -1;
|
|
+ goto error;
|
|
}
|
|
}
|
|
|
|
@@ -1159,14 +1154,14 @@ int hostapd_setup_interface_complete(str
|
|
hostapd_set_rts(hapd, hapd->iconf->rts_threshold)) {
|
|
wpa_printf(MSG_ERROR, "Could not set RTS threshold for "
|
|
"kernel driver");
|
|
- return -1;
|
|
+ goto error;
|
|
}
|
|
|
|
if (hapd->iconf->fragm_threshold > -1 &&
|
|
hostapd_set_frag(hapd, hapd->iconf->fragm_threshold)) {
|
|
wpa_printf(MSG_ERROR, "Could not set fragmentation threshold "
|
|
"for kernel driver");
|
|
- return -1;
|
|
+ goto error;
|
|
}
|
|
|
|
prev_addr = hapd->own_addr;
|
|
@@ -1176,7 +1171,7 @@ int hostapd_setup_interface_complete(str
|
|
if (j)
|
|
os_memcpy(hapd->own_addr, prev_addr, ETH_ALEN);
|
|
if (hostapd_setup_bss(hapd, j == 0))
|
|
- return -1;
|
|
+ goto error;
|
|
if (hostapd_mac_comp_empty(hapd->conf->bssid) == 0)
|
|
prev_addr = hapd->own_addr;
|
|
}
|
|
@@ -1191,7 +1186,7 @@ int hostapd_setup_interface_complete(str
|
|
if (hostapd_driver_commit(hapd) < 0) {
|
|
wpa_printf(MSG_ERROR, "%s: Failed to commit driver "
|
|
"configuration", __func__);
|
|
- return -1;
|
|
+ goto error;
|
|
}
|
|
|
|
/*
|
|
@@ -1216,6 +1211,13 @@ int hostapd_setup_interface_complete(str
|
|
iface->interfaces->terminate_on_error--;
|
|
|
|
return 0;
|
|
+
|
|
+error:
|
|
+ wpa_printf(MSG_ERROR, "Interface initialization failed");
|
|
+ hostapd_set_state(iface, HAPD_IFACE_DISABLED);
|
|
+ if (iface->interfaces && iface->interfaces->terminate_on_error)
|
|
+ eloop_terminate();
|
|
+ return -1;
|
|
}
|
|
|
|
|