mirror of
https://git.openwrt.org/openwrt/openwrt.git
synced 2024-11-24 14:06:15 +00:00
27b816d545
- improve RTL8411b phy-down fixup - remove not needed check in rtl_fw_write_firmware - remove multicast filter limit - improve handling task scheduling - simplify EEE handling - simplify code by using core-provided pcpu stats allocation - add generic rtl_set_eee_txidle_timer function - support setting the EEE tx idle timer on RTL8168h - add support for returning tx_lpi_timer in ethtool get_eee - annotate writes on dev->mtu from ndo_change_mtu() - disable interrupt source RxOverflow - remove detection of chip version 11 (early RTL8168b) Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
28 lines
961 B
Diff
28 lines
961 B
Diff
From 3a767b482cacd9bfeac786837fcac419af315995 Mon Sep 17 00:00:00 2001
|
|
From: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Date: Thu, 23 Nov 2023 10:53:26 +0100
|
|
Subject: [PATCH] r8169: remove not needed check in rtl_fw_write_firmware
|
|
|
|
This check can never be true for a firmware file with a correct format.
|
|
Existing checks in rtl_fw_data_ok() are sufficient, no problems with
|
|
invalid firmware files are known.
|
|
|
|
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/ethernet/realtek/r8169_firmware.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/realtek/r8169_firmware.c
|
|
+++ b/drivers/net/ethernet/realtek/r8169_firmware.c
|
|
@@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl816
|
|
u32 regno = (action & 0x0fff0000) >> 16;
|
|
enum rtl_fw_opcode opcode = action >> 28;
|
|
|
|
- if (!action)
|
|
- break;
|
|
-
|
|
switch (opcode) {
|
|
case PHY_READ:
|
|
predata = fw_read(tp, regno);
|