mirror of
https://git.openwrt.org/openwrt/openwrt.git
synced 2025-05-20 21:27:55 +00:00
dfc3e24bdd
Refreshed patches for generic/backport-6.12 by running make target/linux/refresh Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com> Link: https://github.com/openwrt/openwrt/pull/16547 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
50 lines
1.9 KiB
Diff
50 lines
1.9 KiB
Diff
From d32c4e58545f17caaa854415f854691e32d42075 Mon Sep 17 00:00:00 2001
|
|
From: Geert Uytterhoeven <geert+renesas@glider.be>
|
|
Date: Wed, 26 Mar 2025 15:22:19 +0100
|
|
Subject: [PATCH] spi: SPI_QPIC_SNAND should be tristate and depend on MTD
|
|
|
|
SPI_QPIC_SNAND is the only driver that selects MTD instead of depending
|
|
on it, which could lead to circular dependencies. Moreover, as
|
|
SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to
|
|
be built-in, as can be seen in an allmodconfig kernel.
|
|
|
|
Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND
|
|
cannot be tristate; all MODULE_*() boilerplate is already present.
|
|
Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the
|
|
missing semicolon.
|
|
|
|
Fixes: 7304d1909080ef0c ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
|
|
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
|
|
Link: https://patch.msgid.link/b63db431cbf35223a4400e44c296293d32c4543c.1742998909.git.geert+renesas@glider.be
|
|
Signed-off-by: Mark Brown <broonie@kernel.org>
|
|
---
|
|
drivers/spi/Kconfig | 4 ++--
|
|
drivers/spi/spi-qpic-snand.c | 2 +-
|
|
2 files changed, 3 insertions(+), 3 deletions(-)
|
|
|
|
--- a/drivers/spi/Kconfig
|
|
+++ b/drivers/spi/Kconfig
|
|
@@ -899,9 +899,9 @@ config SPI_QCOM_QSPI
|
|
QSPI(Quad SPI) driver for Qualcomm QSPI controller.
|
|
|
|
config SPI_QPIC_SNAND
|
|
- bool "QPIC SNAND controller"
|
|
+ tristate "QPIC SNAND controller"
|
|
depends on ARCH_QCOM || COMPILE_TEST
|
|
- select MTD
|
|
+ depends on MTD
|
|
help
|
|
QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller.
|
|
QPIC controller supports both parallel nand and serial nand.
|
|
--- a/drivers/spi/spi-qpic-snand.c
|
|
+++ b/drivers/spi/spi-qpic-snand.c
|
|
@@ -1614,7 +1614,7 @@ static const struct of_device_id qcom_sn
|
|
.data = &ipq9574_snandc_props,
|
|
},
|
|
{}
|
|
-}
|
|
+};
|
|
MODULE_DEVICE_TABLE(of, qcom_snandc_of_match);
|
|
|
|
static struct platform_driver qcom_spi_driver = {
|