mirror of
https://git.openwrt.org/openwrt/openwrt.git
synced 2024-11-25 06:26:15 +00:00
8c405cdccc
The patches were generated from the RPi repo with the following command: git format-patch v6.6.34..rpi-6.1.y Some patches needed rebasing and, as usual, the applied and reverted, wireless drivers, Github workflows, READMEs and defconfigs patches were removed. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
44 lines
1.7 KiB
Diff
44 lines
1.7 KiB
Diff
From ee3dafdd4448177c846993302d211adf9cfc55fd Mon Sep 17 00:00:00 2001
|
|
From: Nathan Chancellor <nathan@kernel.org>
|
|
Date: Mon, 31 Jan 2022 17:23:38 -0700
|
|
Subject: [PATCH 0337/1085] media: bcm2835-unicam: Set ret on error path in
|
|
unicam_async_complete()
|
|
|
|
Clang warns:
|
|
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c:3109:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
|
|
if (!source_pads) {
|
|
^~~~~~~~~~~~
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c:3152:9: note: uninitialized use occurs here
|
|
return ret;
|
|
^~~
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c:3109:2: note: remove the 'if' if its condition is always false
|
|
if (!source_pads) {
|
|
^~~~~~~~~~~~~~~~~~~
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c:3091:9: note: initialize the variable 'ret' to silence this warning
|
|
int ret;
|
|
^
|
|
= 0
|
|
1 warning generated.
|
|
|
|
When the if condition is true, ret will be used uninitialized, which
|
|
could result in undesirable behavior. Set ret to -ENODEV on the error
|
|
path, which is a standard error code for the ->complete() callback.
|
|
|
|
Fixes: d056e86eb35f ("media/bcm2835-unicam: Parse pad numbers correctly")
|
|
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
|
|
---
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
--- a/drivers/media/platform/bcm2835/bcm2835-unicam.c
|
|
+++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c
|
|
@@ -3108,6 +3108,7 @@ static int unicam_async_complete(struct
|
|
}
|
|
if (!source_pads) {
|
|
unicam_err(unicam, "No source pads on sensor.\n");
|
|
+ ret = -ENODEV;
|
|
goto unregister;
|
|
}
|
|
|