handleAdd did not work correctly for a while: some state was not cleaned
up (try: wireless -> add -> no changes -> click dismiss -> press save).
The state is now properly removed when pressing dismiss, by stashing
addedSection correctly under the map m and not in this.
Also requires a null check in render_modal_status.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
This patch adds a badge to the associated wireless stations with the vlan id
and name. It is displayed in the same color as the network, to which it is
bridged, so the color corresponds to the color in the network configuration
page.
Signed-off-by: Tobias Waldvogel <tobias.waldvogel@gmail.com>
The protocol defaults to 'none' in netifd if unspecified.
Some previously unused and some now redundant code is also removed.
Signed-off-by: Erik Karlsson <erik.karlsson@iopsys.eu>
Follow-up fix to fb4cf432d2232a0ba2ccd3a8ff81a3679c8d054d
Resolves sync errors:
standard input:682: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.
standard input:733: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.
standard input:761: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.
standard input:818: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
If the value returned from UCI was falsy, it became an empty array instead
of an empty string, which crashed the UI when trying to invoke the
non-existing replace instance function on the value.
Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
otherwise ucode function call breaks with:
RPC call to luci/getInitList failed with error -32000: Object not found
Follow-up fix to ab15b5e379717be5e194bc3992ae13960b973f18
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
The kmod install link only displays in new device dialogues so as not
to be too prominent.
Closes#6996Closes#7086
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
netifd support for bonding devices has been added in commit 5ba9744.
The other way to have bonding available in luci is via
luci-proto-bonding and its proto-bonding dependency.
luci-proto-bonding requires an IP address on a bond interface due to a
netifd limitation. This can cause some issues if you want to bridge an
Ethernet port and a bond.
This patch aims to have the device to be configurable not as an
interface protocol but as a device.
Signed-off-by: Nicolò Veronese <nicveronese@gmail.com>
This is to prepare for the bonding implementation, two configuration
nodes cannot share the same name.
Probably a more unique and precise naming would be better.
Signed-off-by: Nicolò Veronese <nicveronese@gmail.com>
Without validation, `dnsmasq` can fail silently if users enter
invalid leasetime input. This change adds input validation to
align user input with the backend parsing logic. Whilst it does
not enforce the >120 seconds requirement, this is documented
in the field description and handled by `dnsmasq`'s `option.c`,
which adjusts values <120 to meet this minimum.
Signed-off-by: Lyall Beveridge <lyall.beveridge@morsemicro.com>
master and 24 use much newer versions.
This will prevent a read error on the non-existent control file when
the system uses apk.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
This enables cloning of individual routes and rules where one wishes
to make similar entries rapidly.
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Some channels may restrict its use to indoor only. Add support for
this and alert the user if a channel with this limitation is used.
Closes#5695
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Include support in luci to enable the Private PSK.
When Private PSK is enabled, clients can use a default password (common),
or have their own private password that is associate with the client MAC.
The password is retrieved from RADIUS server, asking for the client MAC,
and when such client MAC is not defined, RADIUS should return a default
password.
RADIUS can also return other parameters like VLANs, which can be used to
put clients dinamically in different vlans based on their MAC, or the
default configuration.
Private PSK is not compatible yet with SAE encryption, therefore cannot
be used yet with WPA3 or WPA3-mixed.
It implements the UI for the PPSK already in master: https://github.com/openwrt/openwrt/pull/3509Closes#4513
Signed-off-by: Manuel Giganto <mgigantoregistros@gmail.com>
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
As a convenience at load/save, the hex field de/encodes hex respectively
This follows https://github.com/openwrt/openwrt/pull/14975
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
The previous implementation of binding the protocol validation to the
name validation caused problems when creating a new interface where an
already existing interface had the new one's protocol as its name, as the
protocol would be used when validating if an interface of that name already
existed.
Consider the following case:
1. Interface 'gre' with protocol PPPoE is created
2. Interface 'foo' with protocol GRE tunnel over IPv4 (which resolves to
'gre') tries to be created
Creating interface 'foo' would error out during protocol validation as
'gre' would be passed to the name validation, which in turn would check if
an interface with name 'gre' already exists, which it does.
Instead of reusing the validation logic, simply trigger the name
validation manually as the protocol changes to properly pass the name of
the interface instead of the protocol. This also gives the benefit of
keeping all error states related to the name contained in the appropriate
UI element.
Fixes#7146
Tested-by: Tiago Gaspar <tiagogaspar8@gmail.com>
Signed-off-by: Daniel Nilsson <dannil+github@protonmail.com>
instead of returning a space separated string
follow-up to 5ab0cb1f15bcb31015ae8345d302c6d023ba51e2
Closes#7209
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
