998b973157
* use interface mode switching only when operating in C45 mode Linux prevents switching the interface mode when using C22 MDIO, hence use rate-adapter mode in case the PHY controlled via C22. * use phy_read_paged where appropriate * use existing generic inline functions to handle 10GbE advertisements instead of redundantly defining register macros in realtek.c which are not actually vendor-specific. * make sure 10GbE advertisement is valid, preventing false-positive warning "Downshift occurred from negotiated speed 2.5Gbps to actual speed 1Gbps, check cabling!" with some link-partners using 1G mode. * Support Link Down Power Saving Mode (ALDPS) Signed-off-by: Daniel Golle <daniel@makrotopia.org>
44 lines
1.5 KiB
Diff
44 lines
1.5 KiB
Diff
From 2b1b8c4c215af7988136401c902338d091d408a1 Mon Sep 17 00:00:00 2001
|
|
From: Daniel Golle <daniel@makrotopia.org>
|
|
Date: Mon, 3 Apr 2023 01:21:57 +0300
|
|
Subject: [PATCH 2/2] net: phy: realtek: disable SGMII in-band AN for 2.5G PHYs
|
|
|
|
MAC drivers don't use SGMII in-band autonegotiation unless told to do so
|
|
in device tree using 'managed = "in-band-status"'. When using MDIO to
|
|
access a PHY, in-band-status is unneeded as we have link-status via
|
|
MDIO. Switch off SGMII in-band autonegotiation using magic values.
|
|
|
|
Reported-by: Chen Minqiang <ptpt52@gmail.com>
|
|
Reported-by: Chukun Pan <amadeus@jmu.edu.cn>
|
|
Reported-by: Yevhen Kolomeiko <jarvis2709@gmail.com>
|
|
Tested-by: Yevhen Kolomeiko <jarvis2709@gmail.com>
|
|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
|
---
|
|
drivers/net/phy/realtek.c | 8 ++++++++
|
|
1 file changed, 8 insertions(+)
|
|
|
|
--- a/drivers/net/phy/realtek.c
|
|
+++ b/drivers/net/phy/realtek.c
|
|
@@ -875,6 +875,7 @@ static irqreturn_t rtl9000a_handle_inter
|
|
static int rtl8221b_config_init(struct phy_device *phydev)
|
|
{
|
|
u16 option_mode;
|
|
+ int val;
|
|
|
|
switch (phydev->interface) {
|
|
case PHY_INTERFACE_MODE_2500BASEX:
|
|
@@ -911,6 +912,13 @@ static int rtl8221b_config_init(struct p
|
|
break;
|
|
}
|
|
|
|
+ /* Disable SGMII AN */
|
|
+ phy_write_mmd(phydev, RTL8221B_MMD_SERDES_CTRL, 0x7588, 0x2);
|
|
+ phy_write_mmd(phydev, RTL8221B_MMD_SERDES_CTRL, 0x7589, 0x71d0);
|
|
+ phy_write_mmd(phydev, RTL8221B_MMD_SERDES_CTRL, 0x7587, 0x3);
|
|
+ phy_read_mmd_poll_timeout(phydev, RTL8221B_MMD_SERDES_CTRL, 0x7587,
|
|
+ val, !(val & BIT(0)), 500, 100000, false);
|
|
+
|
|
return 0;
|
|
}
|
|
|