34d2964554
Fixes issues with RTL8156 2.5G USB adapters
- # ethtool eth1
Settings for eth1:
Supported ports: [ ]
Supported link modes: Not reported
Supported pause frame use: No
Supports auto-negotiation: No
Supported FEC modes: Not reported
Advertised link modes: Not reported
Advertised pause frame use: No
Advertised auto-negotiation: No
Advertised FEC modes: Not reported
Speed: 2500Mb/s
Duplex: Half
Port: Twisted Pair
PHYAD: 0
Transceiver: internal
Auto-negotiation: off
MDI-X: Unknown
Current message level: 0x00000007 (7)
drv probe link
Link detected: yes
- #
- r8152: break the loop when the budget is exhausted
- r8152: Block future register access if register access fails
- r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE
- r8152: add vendor/device ID pair for D-Link DUB-E250
- r8152: try to use a normal budget
- r8152: set bp in bulk
- r8152: adjust generic_ocp_write function
- r8152: fix the autosuspend doesn't work
- r8152: Add __GFP_NOWARN to big allocations
- r8152: reduce the control transfer of rtl8152_get_version()
- r8152: remove rtl_vendor_mode function
- r8152: avoid to change cfg for all devices
- r8152: add USB device driver for config selection
- r8152: use napi_gro_frags
- cdc_ether: no need to blacklist any r8152 devices
- cdc_ether: add u-blox 0x1313 composition
Build system: x86_64
Build-tested: bcm2711, rockchip, x86/64
Run-tested: bcm2711/RPi4B, rockchip/nanopi r2s, x86/64
Signed-off-by: Marty Jones <mj8263788@gmail.com>
123 lines
3.5 KiB
Diff
123 lines
3.5 KiB
Diff
From 788d30daa8f97f06166b6a63f0e51f2a4c2f036a Mon Sep 17 00:00:00 2001
|
|
From: Hayes Wang <hayeswang@realtek.com>
|
|
Date: Tue, 26 Sep 2023 19:17:14 +0800
|
|
Subject: [PATCH] r8152: use napi_gro_frags
|
|
|
|
Use napi_gro_frags() for the skb of fragments when the work_done is less
|
|
than budget.
|
|
|
|
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
|
|
Link: https://lore.kernel.org/r/20230926111714.9448-434-nic_swsd@realtek.com
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/usb/r8152.c | 67 ++++++++++++++++++++++++++++++-----------
|
|
1 file changed, 50 insertions(+), 17 deletions(-)
|
|
|
|
--- a/drivers/net/usb/r8152.c
|
|
+++ b/drivers/net/usb/r8152.c
|
|
@@ -2583,8 +2583,9 @@ static int rx_bottom(struct r8152 *tp, i
|
|
while (urb->actual_length > len_used) {
|
|
struct net_device *netdev = tp->netdev;
|
|
struct net_device_stats *stats = &netdev->stats;
|
|
- unsigned int pkt_len, rx_frag_head_sz;
|
|
+ unsigned int pkt_len, rx_frag_head_sz, len;
|
|
struct sk_buff *skb;
|
|
+ bool use_frags;
|
|
|
|
WARN_ON_ONCE(skb_queue_len(&tp->rx_queue) >= 1000);
|
|
|
|
@@ -2597,45 +2598,77 @@ static int rx_bottom(struct r8152 *tp, i
|
|
break;
|
|
|
|
pkt_len -= ETH_FCS_LEN;
|
|
+ len = pkt_len;
|
|
rx_data += sizeof(struct rx_desc);
|
|
|
|
- if (!agg_free || tp->rx_copybreak > pkt_len)
|
|
- rx_frag_head_sz = pkt_len;
|
|
+ if (!agg_free || tp->rx_copybreak > len)
|
|
+ use_frags = false;
|
|
else
|
|
- rx_frag_head_sz = tp->rx_copybreak;
|
|
+ use_frags = true;
|
|
+
|
|
+ if (use_frags) {
|
|
+ /* If the budget is exhausted, the packet
|
|
+ * would be queued in the driver. That is,
|
|
+ * napi_gro_frags() wouldn't be called, so
|
|
+ * we couldn't use napi_get_frags().
|
|
+ */
|
|
+ if (work_done >= budget) {
|
|
+ rx_frag_head_sz = tp->rx_copybreak;
|
|
+ skb = napi_alloc_skb(napi,
|
|
+ rx_frag_head_sz);
|
|
+ } else {
|
|
+ rx_frag_head_sz = 0;
|
|
+ skb = napi_get_frags(napi);
|
|
+ }
|
|
+ } else {
|
|
+ rx_frag_head_sz = 0;
|
|
+ skb = napi_alloc_skb(napi, len);
|
|
+ }
|
|
|
|
- skb = napi_alloc_skb(napi, rx_frag_head_sz);
|
|
if (!skb) {
|
|
stats->rx_dropped++;
|
|
goto find_next_rx;
|
|
}
|
|
|
|
skb->ip_summed = r8152_rx_csum(tp, rx_desc);
|
|
- memcpy(skb->data, rx_data, rx_frag_head_sz);
|
|
- skb_put(skb, rx_frag_head_sz);
|
|
- pkt_len -= rx_frag_head_sz;
|
|
- rx_data += rx_frag_head_sz;
|
|
- if (pkt_len) {
|
|
+ rtl_rx_vlan_tag(rx_desc, skb);
|
|
+
|
|
+ if (use_frags) {
|
|
+ if (rx_frag_head_sz) {
|
|
+ memcpy(skb->data, rx_data,
|
|
+ rx_frag_head_sz);
|
|
+ skb_put(skb, rx_frag_head_sz);
|
|
+ len -= rx_frag_head_sz;
|
|
+ rx_data += rx_frag_head_sz;
|
|
+ skb->protocol = eth_type_trans(skb,
|
|
+ netdev);
|
|
+ }
|
|
+
|
|
skb_add_rx_frag(skb, 0, agg->page,
|
|
agg_offset(agg, rx_data),
|
|
- pkt_len,
|
|
- SKB_DATA_ALIGN(pkt_len));
|
|
+ len, SKB_DATA_ALIGN(len));
|
|
get_page(agg->page);
|
|
+ } else {
|
|
+ memcpy(skb->data, rx_data, len);
|
|
+ skb_put(skb, len);
|
|
+ skb->protocol = eth_type_trans(skb, netdev);
|
|
}
|
|
|
|
- skb->protocol = eth_type_trans(skb, netdev);
|
|
- rtl_rx_vlan_tag(rx_desc, skb);
|
|
if (work_done < budget) {
|
|
+ if (use_frags)
|
|
+ napi_gro_frags(napi);
|
|
+ else
|
|
+ napi_gro_receive(napi, skb);
|
|
+
|
|
work_done++;
|
|
stats->rx_packets++;
|
|
- stats->rx_bytes += skb->len;
|
|
- napi_gro_receive(napi, skb);
|
|
+ stats->rx_bytes += pkt_len;
|
|
} else {
|
|
__skb_queue_tail(&tp->rx_queue, skb);
|
|
}
|
|
|
|
find_next_rx:
|
|
- rx_data = rx_agg_align(rx_data + pkt_len + ETH_FCS_LEN);
|
|
+ rx_data = rx_agg_align(rx_data + len + ETH_FCS_LEN);
|
|
rx_desc = (struct rx_desc *)rx_data;
|
|
len_used = agg_offset(agg, rx_data);
|
|
len_used += sizeof(struct rx_desc);
|