Changes in 4.9.249 spi: bcm2835aux: Fix use-after-free on unbind spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe iwlwifi: pcie: limit memory read spin time arm64: dts: rockchip: Assign a fixed index to mmc devices on rk3399 boards. ARC: stack unwinding: don't assume non-current task is sleeping platform/x86: acer-wmi: add automatic keyboard background light toggle key as KEY_LIGHTS_TOGGLE Input: cm109 - do not stomp on control URB Input: i8042 - add Acer laptops to the i8042 reset list pinctrl: amd: remove debounce filter setting in IRQ type setting scsi: be2iscsi: Revert "Fix a theoretical leak in beiscsi_create_eqs()" spi: Prevent adding devices below an unregistering controller net/mlx4_en: Avoid scheduling restart task if it is already running tcp: fix cwnd-limited bug for TSO deferral where we send nothing net: stmmac: delete the eee_ctrl_timer after napi disabled net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux net: bridge: vlan: fix error return code in __vlan_add() mac80211: mesh: fix mesh_pathtbl_init() error path USB: dummy-hcd: Fix uninitialized array use in init() USB: add RESET_RESUME quirk for Snapscan 1212 ALSA: usb-audio: Fix potential out-of-bounds shift ALSA: usb-audio: Fix control 'access overflow' errors from chmap xhci: Give USB2 ports time to enter U3 in bus suspend USB: sisusbvga: Make console support depend on BROKEN ALSA: pcm: oss: Fix potential out-of-bounds shift serial: 8250_omap: Avoid FIFO corruption caused by MDR1 access pinctrl: merrifield: Set default bias in case no particular value given pinctrl: baytrail: Avoid clearing debounce value when turning it off scsi: bnx2i: Requires MMU can: softing: softing_netdev_open(): fix error handling RDMA/cm: Fix an attempt to use non-valid pointer when cleaning timewait kernel/cpu: add arch override for clear_tasks_mm_cpumask() mm handling drm/tegra: sor: Disable clocks on error in tegra_sor_init() scsi: mpt3sas: Increase IOCInit request timeout to 30s dm table: Remove BUG_ON(in_interrupt()) soc/tegra: fuse: Fix index bug in get_process_id USB: serial: option: add interface-number sanity check to flag handling USB: gadget: f_acm: add support for SuperSpeed Plus USB: gadget: f_midi: setup SuperSpeed Plus descriptors USB: gadget: f_rndis: fix bitrate for SuperSpeed and above usb: gadget: f_fs: Re-use SS descriptors for SuperSpeedPlus usb: chipidea: ci_hdrc_imx: Pass DISABLE_DEVICE_STREAMING flag to imx6ul ARM: dts: exynos: fix roles of USB 3.0 ports on Odroid XU ARM: dts: exynos: fix USB 3.0 VBUS control and over-current pins on Exynos5410 ARM: dts: exynos: fix USB 3.0 pins supply being turned off on Odroid XU HID: i2c-hid: add Vero K147 to descriptor override serial_core: Check for port state when tty is in error state media: msi2500: assign SPI bus number dynamically md: fix a warning caused by a race between concurrent md_ioctl()s Bluetooth: Fix slab-out-of-bounds read in hci_le_direct_adv_report_evt() drm/gma500: fix double free of gma_connector RDMA/rxe: Compute PSN windows correctly ARM: p2v: fix handling of LPAE translation in BE mode crypto: talitos - Fix return type of current_desc_hdr() spi: img-spfi: fix reference leak in img_spfi_resume ASoC: pcm: DRAIN support reactivation arm64: dts: exynos: Correct psci compatible used on Exynos7 Bluetooth: Fix null pointer dereference in hci_event_packet() spi: spi-ti-qspi: fix reference leak in ti_qspi_setup spi: tegra20-slink: fix reference leak in slink ops of tegra20 spi: tegra20-sflash: fix reference leak in tegra_sflash_resume spi: tegra114: fix reference leak in tegra spi ops RDMa/mthca: Work around -Wenum-conversion warning MIPS: BCM47XX: fix kconfig dependency bug for BCM47XX_BCMA staging: greybus: codecs: Fix reference counter leak in error handling media: solo6x10: fix missing snd_card_free in error handling case drm/omap: dmm_tiler: fix return error code in omap_dmm_probe() Input: ads7846 - fix integer overflow on Rt calculation Input: ads7846 - fix unaligned access on 7845 powerpc/feature: Fix CPU_FTRS_ALWAYS by removing CPU_FTRS_GENERIC_32 crypto: omap-aes - Fix PM disable depth imbalance in omap_aes_probe soc: ti: knav_qmss: fix reference leak in knav_queue_probe soc: ti: Fix reference imbalance in knav_dma_probe drivers: soc: ti: knav_qmss_queue: Fix error return code in knav_queue_probe RDMA/cxgb4: Validate the number of CQEs memstick: fix a double-free bug in memstick_check ARM: dts: at91: sama5d4_xplained: add pincontrol for USB Host ARM: dts: at91: sama5d3_xplained: add pincontrol for USB Host orinoco: Move context allocation after processing the skb cw1200: fix missing destroy_workqueue() on error in cw1200_init_common media: siano: fix memory leak of debugfs members in smsdvb_hotplug mips: cdmm: fix use-after-free in mips_cdmm_bus_discover HSI: omap_ssi: Don't jump to free ID in ssi_add_controller() ARM: dts: at91: at91sam9rl: fix ADC triggers NFSv4.2: condition READDIR's mask for security label based on LSM state SUNRPC: xprt_load_transport() needs to support the netid "rdma6" lockd: don't use interval-based rebinding over TCP NFS: switch nfsiod to be an UNBOUND workqueue. vfio-pci: Use io_remap_pfn_range() for PCI IO memory media: saa7146: fix array overflow in vidioc_s_audio() clocksource/drivers/cadence_ttc: Fix memory leak in ttc_setup_clockevent() pinctrl: falcon: add missing put_device() call in pinctrl_falcon_probe() memstick: r592: Fix error return in r592_probe() ASoC: jz4740-i2s: add missed checks for clk_get() dm ioctl: fix error return code in target_message clocksource/drivers/arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI cpufreq: highbank: Add missing MODULE_DEVICE_TABLE cpufreq: st: Add missing MODULE_DEVICE_TABLE cpufreq: loongson1: Add missing MODULE_ALIAS cpufreq: scpi: Add missing MODULE_ALIAS scsi: pm80xx: Fix error return in pm8001_pci_probe() seq_buf: Avoid type mismatch for seq_buf_init scsi: fnic: Fix error return code in fnic_probe() powerpc/pseries/hibernation: drop pseries_suspend_begin() from suspend ops usb: ehci-omap: Fix PM disable depth umbalance in ehci_hcd_omap_probe usb: oxu210hp-hcd: Fix memory leak in oxu_create speakup: fix uninitialized flush_lock nfsd: Fix message level for normal termination nfs_common: need lock during iterate through the list x86/kprobes: Restore BTF if the single-stepping is cancelled clk: tegra: Fix duplicated SE clock entry extcon: max77693: Fix modalias string ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control() irqchip/alpine-msi: Fix freeing of interrupts on allocation error path um: chan_xterm: Fix fd leak nfc: s3fwrn5: Release the nfc firmware powerpc/ps3: use dma_mapping_error() checkpatch: fix unescaped left brace net: bcmgenet: Fix a resource leak in an error handling path in the probe functin net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function net: korina: fix return value watchdog: qcom: Avoid context switch in restart handler clk: ti: Fix memleak in ti_fapll_synth_setup perf record: Fix memory leak when using '--user-regs=?' to list registers qlcnic: Fix error code in probe clk: s2mps11: Fix a resource leak in error handling paths in the probe function cfg80211: initialize rekey_data Input: cros_ec_keyb - send 'scancodes' in addition to key events Input: goodix - add upside-down quirk for Teclast X98 Pro tablet media: gspca: Fix memory leak in probe media: sunxi-cir: ensure IR is handled when it is continuous media: netup_unidvb: Don't leak SPI master in probe error path Input: cyapa_gen6 - fix out-of-bounds stack access Revert "ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks" ACPI: PNP: compare the string length in the matching_id() ALSA: pcm: oss: Fix a few more UBSAN fixes ALSA: usb-audio: Disable sample read check if firmware doesn't give back s390/dasd: prevent inconsistent LCU device data s390/dasd: fix list corruption of pavgroup group list s390/dasd: fix list corruption of lcu list staging: comedi: mf6x4: Fix AI end-of-conversion detection powerpc/perf: Exclude kernel samples while counting events in user space. USB: serial: mos7720: fix parallel-port state restore USB: serial: keyspan_pda: fix dropped unthrottle interrupts USB: serial: keyspan_pda: fix write deadlock USB: serial: keyspan_pda: fix stalled writes USB: serial: keyspan_pda: fix write-wakeup use-after-free USB: serial: keyspan_pda: fix tx-unthrottle use-after-free USB: serial: keyspan_pda: fix write unthrottling btrfs: quota: Set rescan progress to (u64)-1 if we hit last leaf btrfs: scrub: Don't use inode page cache in scrub_handle_errored_block() Btrfs: fix selftests failure due to uninitialized i_mode in test inodes btrfs: fix return value mixup in btrfs_get_extent ext4: fix a memory leak of ext4_free_data KVM: arm64: Introduce handling of AArch32 TTBCR2 traps powerpc/xmon: Change printk() to pr_cont() ceph: fix race in concurrent __ceph_remove_cap invocations jffs2: Fix GC exit abnormally jfs: Fix array index bounds check in dbAdjTree drm/dp_aux_dev: check aux_dev before use in drm_dp_aux_dev_get_by_minor() spi: spi-sh: Fix use-after-free on unbind spi: davinci: Fix use-after-free on unbind spi: pic32: Don't leak DMA channels in probe error path spi: rb4xx: Don't leak SPI master in probe error path spi: sc18is602: Don't leak SPI master in probe error path spi: st-ssc4: Fix unbalanced pm_runtime_disable() in probe error path soc: qcom: smp2p: Safely acquire spinlock without IRQs mtd: parser: cmdline: Fix parsing of part-names with colons iio: buffer: Fix demux update iio: adc: rockchip_saradc: fix missing clk_disable_unprepare() on error in rockchip_saradc_resume iio:pressure:mpl3115: Force alignment of buffer clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9 xen-blkback: set ring->xenblkd to NULL after kthread_stop() PCI: Fix pci_slot_release() NULL pointer dereference Linux 4.9.249 Signed-off-by: Greg Kroah-Hartman <gregkh@google.com> Change-Id: I4829a32e2ea6e76eefea716f35f42ee02b75c265
312 lines
8.4 KiB
C
312 lines
8.4 KiB
C
/*
|
|
* ChromeOS EC keyboard driver
|
|
*
|
|
* Copyright (C) 2012 Google, Inc
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* This driver uses the Chrome OS EC byte-level message-based protocol for
|
|
* communicating the keyboard state (which keys are pressed) from a keyboard EC
|
|
* to the AP over some bus (such as i2c, lpc, spi). The EC does debouncing,
|
|
* but everything else (including deghosting) is done here. The main
|
|
* motivation for this is to keep the EC firmware as simple as possible, since
|
|
* it cannot be easily upgraded and EC flash/IRAM space is relatively
|
|
* expensive.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/input.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/input/matrix_keypad.h>
|
|
#include <linux/mfd/cros_ec.h>
|
|
#include <linux/mfd/cros_ec_commands.h>
|
|
|
|
/*
|
|
* @rows: Number of rows in the keypad
|
|
* @cols: Number of columns in the keypad
|
|
* @row_shift: log2 or number of rows, rounded up
|
|
* @keymap_data: Matrix keymap data used to convert to keyscan values
|
|
* @ghost_filter: true to enable the matrix key-ghosting filter
|
|
* @valid_keys: bitmap of existing keys for each matrix column
|
|
* @old_kb_state: bitmap of keys pressed last scan
|
|
* @dev: Device pointer
|
|
* @idev: Input device
|
|
* @ec: Top level ChromeOS device to use to talk to EC
|
|
* @notifier: interrupt event notifier for transport devices
|
|
*/
|
|
struct cros_ec_keyb {
|
|
unsigned int rows;
|
|
unsigned int cols;
|
|
int row_shift;
|
|
const struct matrix_keymap_data *keymap_data;
|
|
bool ghost_filter;
|
|
uint8_t *valid_keys;
|
|
uint8_t *old_kb_state;
|
|
|
|
struct device *dev;
|
|
struct input_dev *idev;
|
|
struct cros_ec_device *ec;
|
|
struct notifier_block notifier;
|
|
};
|
|
|
|
|
|
/*
|
|
* Returns true when there is at least one combination of pressed keys that
|
|
* results in ghosting.
|
|
*/
|
|
static bool cros_ec_keyb_has_ghosting(struct cros_ec_keyb *ckdev, uint8_t *buf)
|
|
{
|
|
int col1, col2, buf1, buf2;
|
|
struct device *dev = ckdev->dev;
|
|
uint8_t *valid_keys = ckdev->valid_keys;
|
|
|
|
/*
|
|
* Ghosting happens if for any pressed key X there are other keys
|
|
* pressed both in the same row and column of X as, for instance,
|
|
* in the following diagram:
|
|
*
|
|
* . . Y . g .
|
|
* . . . . . .
|
|
* . . . . . .
|
|
* . . X . Z .
|
|
*
|
|
* In this case only X, Y, and Z are pressed, but g appears to be
|
|
* pressed too (see Wikipedia).
|
|
*/
|
|
for (col1 = 0; col1 < ckdev->cols; col1++) {
|
|
buf1 = buf[col1] & valid_keys[col1];
|
|
for (col2 = col1 + 1; col2 < ckdev->cols; col2++) {
|
|
buf2 = buf[col2] & valid_keys[col2];
|
|
if (hweight8(buf1 & buf2) > 1) {
|
|
dev_dbg(dev, "ghost found at: B[%02d]:0x%02x & B[%02d]:0x%02x",
|
|
col1, buf1, col2, buf2);
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
|
|
/*
|
|
* Compares the new keyboard state to the old one and produces key
|
|
* press/release events accordingly. The keyboard state is 13 bytes (one byte
|
|
* per column)
|
|
*/
|
|
static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev,
|
|
uint8_t *kb_state, int len)
|
|
{
|
|
struct input_dev *idev = ckdev->idev;
|
|
int col, row;
|
|
int new_state;
|
|
int old_state;
|
|
int num_cols;
|
|
|
|
num_cols = len;
|
|
|
|
if (ckdev->ghost_filter && cros_ec_keyb_has_ghosting(ckdev, kb_state)) {
|
|
/*
|
|
* Simple-minded solution: ignore this state. The obvious
|
|
* improvement is to only ignore changes to keys involved in
|
|
* the ghosting, but process the other changes.
|
|
*/
|
|
dev_dbg(ckdev->dev, "ghosting found\n");
|
|
return;
|
|
}
|
|
|
|
for (col = 0; col < ckdev->cols; col++) {
|
|
for (row = 0; row < ckdev->rows; row++) {
|
|
int pos = MATRIX_SCAN_CODE(row, col, ckdev->row_shift);
|
|
const unsigned short *keycodes = idev->keycode;
|
|
|
|
new_state = kb_state[col] & (1 << row);
|
|
old_state = ckdev->old_kb_state[col] & (1 << row);
|
|
if (new_state != old_state) {
|
|
dev_dbg(ckdev->dev,
|
|
"changed: [r%d c%d]: byte %02x\n",
|
|
row, col, new_state);
|
|
|
|
input_event(idev, EV_MSC, MSC_SCAN, pos);
|
|
input_report_key(idev, keycodes[pos],
|
|
new_state);
|
|
}
|
|
}
|
|
ckdev->old_kb_state[col] = kb_state[col];
|
|
}
|
|
input_sync(ckdev->idev);
|
|
}
|
|
|
|
static int cros_ec_keyb_open(struct input_dev *dev)
|
|
{
|
|
struct cros_ec_keyb *ckdev = input_get_drvdata(dev);
|
|
|
|
return blocking_notifier_chain_register(&ckdev->ec->event_notifier,
|
|
&ckdev->notifier);
|
|
}
|
|
|
|
static void cros_ec_keyb_close(struct input_dev *dev)
|
|
{
|
|
struct cros_ec_keyb *ckdev = input_get_drvdata(dev);
|
|
|
|
blocking_notifier_chain_unregister(&ckdev->ec->event_notifier,
|
|
&ckdev->notifier);
|
|
}
|
|
|
|
static int cros_ec_keyb_work(struct notifier_block *nb,
|
|
unsigned long queued_during_suspend, void *_notify)
|
|
{
|
|
struct cros_ec_keyb *ckdev = container_of(nb, struct cros_ec_keyb,
|
|
notifier);
|
|
|
|
if (ckdev->ec->event_data.event_type != EC_MKBP_EVENT_KEY_MATRIX)
|
|
return NOTIFY_DONE;
|
|
/*
|
|
* If EC is not the wake source, discard key state changes during
|
|
* suspend.
|
|
*/
|
|
if (queued_during_suspend)
|
|
return NOTIFY_OK;
|
|
if (ckdev->ec->event_size != ckdev->cols) {
|
|
dev_err(ckdev->dev,
|
|
"Discarded incomplete key matrix event.\n");
|
|
return NOTIFY_OK;
|
|
}
|
|
cros_ec_keyb_process(ckdev, ckdev->ec->event_data.data.key_matrix,
|
|
ckdev->ec->event_size);
|
|
return NOTIFY_OK;
|
|
}
|
|
|
|
/*
|
|
* Walks keycodes flipping bit in buffer COLUMNS deep where bit is ROW. Used by
|
|
* ghosting logic to ignore NULL or virtual keys.
|
|
*/
|
|
static void cros_ec_keyb_compute_valid_keys(struct cros_ec_keyb *ckdev)
|
|
{
|
|
int row, col;
|
|
int row_shift = ckdev->row_shift;
|
|
unsigned short *keymap = ckdev->idev->keycode;
|
|
unsigned short code;
|
|
|
|
BUG_ON(ckdev->idev->keycodesize != sizeof(*keymap));
|
|
|
|
for (col = 0; col < ckdev->cols; col++) {
|
|
for (row = 0; row < ckdev->rows; row++) {
|
|
code = keymap[MATRIX_SCAN_CODE(row, col, row_shift)];
|
|
if (code && (code != KEY_BATTERY))
|
|
ckdev->valid_keys[col] |= 1 << row;
|
|
}
|
|
dev_dbg(ckdev->dev, "valid_keys[%02d] = 0x%02x\n",
|
|
col, ckdev->valid_keys[col]);
|
|
}
|
|
}
|
|
|
|
static int cros_ec_keyb_probe(struct platform_device *pdev)
|
|
{
|
|
struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
|
|
struct device *dev = &pdev->dev;
|
|
struct cros_ec_keyb *ckdev;
|
|
struct input_dev *idev;
|
|
struct device_node *np;
|
|
int err;
|
|
|
|
np = pdev->dev.of_node;
|
|
if (!np)
|
|
return -ENODEV;
|
|
|
|
ckdev = devm_kzalloc(dev, sizeof(*ckdev), GFP_KERNEL);
|
|
if (!ckdev)
|
|
return -ENOMEM;
|
|
err = matrix_keypad_parse_of_params(dev, &ckdev->rows, &ckdev->cols);
|
|
if (err)
|
|
return err;
|
|
|
|
ckdev->valid_keys = devm_kzalloc(dev, ckdev->cols, GFP_KERNEL);
|
|
if (!ckdev->valid_keys)
|
|
return -ENOMEM;
|
|
|
|
ckdev->old_kb_state = devm_kzalloc(dev, ckdev->cols, GFP_KERNEL);
|
|
if (!ckdev->old_kb_state)
|
|
return -ENOMEM;
|
|
|
|
idev = devm_input_allocate_device(dev);
|
|
if (!idev)
|
|
return -ENOMEM;
|
|
|
|
ckdev->ec = ec;
|
|
ckdev->notifier.notifier_call = cros_ec_keyb_work;
|
|
ckdev->dev = dev;
|
|
dev_set_drvdata(dev, ckdev);
|
|
|
|
idev->name = CROS_EC_DEV_NAME;
|
|
idev->phys = ec->phys_name;
|
|
__set_bit(EV_REP, idev->evbit);
|
|
|
|
idev->id.bustype = BUS_VIRTUAL;
|
|
idev->id.version = 1;
|
|
idev->id.product = 0;
|
|
idev->dev.parent = dev;
|
|
idev->open = cros_ec_keyb_open;
|
|
idev->close = cros_ec_keyb_close;
|
|
|
|
ckdev->ghost_filter = of_property_read_bool(np,
|
|
"google,needs-ghost-filter");
|
|
|
|
err = matrix_keypad_build_keymap(NULL, NULL, ckdev->rows, ckdev->cols,
|
|
NULL, idev);
|
|
if (err) {
|
|
dev_err(dev, "cannot build key matrix\n");
|
|
return err;
|
|
}
|
|
|
|
ckdev->row_shift = get_count_order(ckdev->cols);
|
|
|
|
input_set_capability(idev, EV_MSC, MSC_SCAN);
|
|
input_set_drvdata(idev, ckdev);
|
|
ckdev->idev = idev;
|
|
cros_ec_keyb_compute_valid_keys(ckdev);
|
|
|
|
err = input_register_device(ckdev->idev);
|
|
if (err) {
|
|
dev_err(dev, "cannot register input device\n");
|
|
return err;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id cros_ec_keyb_of_match[] = {
|
|
{ .compatible = "google,cros-ec-keyb" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, cros_ec_keyb_of_match);
|
|
#endif
|
|
|
|
static struct platform_driver cros_ec_keyb_driver = {
|
|
.probe = cros_ec_keyb_probe,
|
|
.driver = {
|
|
.name = "cros-ec-keyb",
|
|
.of_match_table = of_match_ptr(cros_ec_keyb_of_match),
|
|
},
|
|
};
|
|
|
|
module_platform_driver(cros_ec_keyb_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("ChromeOS EC keyboard driver");
|
|
MODULE_ALIAS("platform:cros-ec-keyb");
|